chrome/browser/extensions/api/identity/identity_api.h - Issue 14081014: Identity API: Change WebAuthFlow to use <webview> instead of a normal browser pop-up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_api.h

Issue 14081014: Identity API: Change WebAuthFlow to use <webview> instead of a normal browser pop-up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: chrome.identity side-by-side with chrome.experimental.identity Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/experimental_web_auth_flow_unittest.cc ('k') | chrome/browser/extensions/api/identity/identity_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_api.h

diff --git a/chrome/browser/extensions/api/identity/identity_api.h b/chrome/browser/extensions/api/identity/identity_api.h

index 9819850738a1bd6db3d09e9a679571b0c7dd09e9..1ede33408b7a2cff0586be50dd6ea122978208ed 100644

--- a/chrome/browser/extensions/api/identity/identity_api.h

+++ b/chrome/browser/extensions/api/identity/identity_api.h

@@ -167,6 +167,7 @@ class IdentityLaunchWebAuthFlowFunction : public AsyncExtensionFunction,

// WebAuthFlow::Delegate implementation.

virtual void OnAuthFlowFailure(WebAuthFlow::Failure failure) OVERRIDE;

virtual void OnAuthFlowURLChange(const GURL& redirect_url) OVERRIDE;

+ virtual void OnAuthFlowClosed() OVERRIDE;

// Helper to initialize final URLs vector.

void InitFinalRedirectURLPrefixes(const std::string& extension_id);