third_party/WebKit/Source/web/OpenedFrameTracker.h - Issue 1408073006: Gracefully handle a self-referential opener in frame swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/OpenedFrameTracker.h

Issue 1408073006: Gracefully handle a self-referential opener in frame swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove friend declaration. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/OpenedFrameTracker.h

diff --git a/third_party/WebKit/Source/web/OpenedFrameTracker.h b/third_party/WebKit/Source/web/OpenedFrameTracker.h

index 1b5bbb6dc1504382e61c8ee10682f7a03d57d31e..79beaa2c291331c96217ecd5d8eb5f353cb11eb5 100644

--- a/third_party/WebKit/Source/web/OpenedFrameTracker.h

+++ b/third_party/WebKit/Source/web/OpenedFrameTracker.h

@@ -27,8 +27,9 @@ public:

void add(WebFrame*);

void remove(WebFrame*);

- // Updates the opener for all tracked frames.

- void updateOpener(WebFrame*);

+ // Helper used when swapping a frame into the frame tree: this updates the

+ // opener for opened frames to point to the new frame being swapped in.

+ void transferTo(WebFrame*);

void traceFrames(Visitor*);

void traceFrames(InlinedGlobalMarkingVisitor);

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/OpenedFrameTracker.cpp » ('j') | third_party/WebKit/Source/web/OpenedFrameTracker.cpp » ('J')