Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: third_party/WebKit/Source/web/OpenedFrameTracker.h

Issue 1408073006: Gracefully handle a self-referential opener in frame swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove friend declaration. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef OpenedFrameTracker_h 5 #ifndef OpenedFrameTracker_h
6 #define OpenedFrameTracker_h 6 #define OpenedFrameTracker_h
7 7
8 #include "wtf/HashSet.h" 8 #include "wtf/HashSet.h"
9 #include "wtf/Noncopyable.h" 9 #include "wtf/Noncopyable.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 class Visitor; 13 class Visitor;
14 class InlinedGlobalMarkingVisitor; 14 class InlinedGlobalMarkingVisitor;
15 class WebFrame; 15 class WebFrame;
16 16
17 // Small helper class to track the set of frames that a WebFrame has opened. 17 // Small helper class to track the set of frames that a WebFrame has opened.
18 // Due to layering restrictions, we need to hide the implementation, since 18 // Due to layering restrictions, we need to hide the implementation, since
19 // public/web/ cannot depend on wtf/. 19 // public/web/ cannot depend on wtf/.
20 class OpenedFrameTracker { 20 class OpenedFrameTracker {
21 WTF_MAKE_NONCOPYABLE(OpenedFrameTracker); 21 WTF_MAKE_NONCOPYABLE(OpenedFrameTracker);
22 public: 22 public:
23 OpenedFrameTracker(); 23 OpenedFrameTracker();
24 ~OpenedFrameTracker(); 24 ~OpenedFrameTracker();
25 25
26 bool isEmpty() const; 26 bool isEmpty() const;
27 void add(WebFrame*); 27 void add(WebFrame*);
28 void remove(WebFrame*); 28 void remove(WebFrame*);
29 29
30 // Updates the opener for all tracked frames. 30 // Helper used when swapping a frame into the frame tree: this updates the
31 void updateOpener(WebFrame*); 31 // opener for opened frames to point to the new frame being swapped in.
32 void transferTo(WebFrame*);
32 33
33 void traceFrames(Visitor*); 34 void traceFrames(Visitor*);
34 void traceFrames(InlinedGlobalMarkingVisitor); 35 void traceFrames(InlinedGlobalMarkingVisitor);
35 36
36 private: 37 private:
37 template <typename VisitorDispatcher> 38 template <typename VisitorDispatcher>
38 void traceFramesImpl(VisitorDispatcher); 39 void traceFramesImpl(VisitorDispatcher);
39 40
40 WTF::HashSet<WebFrame*> m_openedFrames; 41 WTF::HashSet<WebFrame*> m_openedFrames;
41 }; 42 };
42 43
43 } // namespace blink 44 } // namespace blink
44 45
45 #endif // WebFramePrivate_h 46 #endif // WebFramePrivate_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698