core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp - Issue 1408063016: Fix a leak in CPDF_Type3Font::LoadChar().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

Issue 1408063016: Fix a leak in CPDF_Type3Font::LoadChar(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@parser_b268

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

diff --git a/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp b/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

index 89ac8ac1438e3e9ef403dc31d9bdbbcc6e165b66..cf737b15f67a2c346f0746c1db5500f48fb07134 100644

--- a/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

+++ b/core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

@@ -128,7 +128,7 @@ CFX_GlyphBitmap* CPDF_Type3Cache::RenderGlyph(CPDF_Type3Glyphs* pSize,

const CFX_AffineMatrix* pMatrix,

FX_FLOAT retinaScaleX,

FX_FLOAT retinaScaleY) {

- CPDF_Type3Char* pChar = m_pFont->LoadChar(charcode);

+ const CPDF_Type3Char* pChar = m_pFont->LoadChar(charcode);

if (pChar == NULL || pChar->m_pBitmap == NULL) {

Tom Sepez 2015/11/08 04:46:29 nit: nullptr twice here and next line.

Lei Zhang 2015/11/09 20:27:26 Done.

return NULL;

}