Fix a leak in CPDF_Type3Font::LoadChar().

core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #include "../../../include/fpdfapi/fpdf_render.h"
 #include "../../../include/fpdfapi/fpdf_pageobj.h"
 #include "../fpdf_page/pageint.h"
@@ skipping 110 matching lines @@
     }
     line += line_step;
   }
   return -1;
 }
 CFX_GlyphBitmap* CPDF_Type3Cache::RenderGlyph(CPDF_Type3Glyphs* pSize,
                                               FX_DWORD charcode,
                                               const CFX_AffineMatrix* pMatrix,
                                               FX_FLOAT retinaScaleX,
                                               FX_FLOAT retinaScaleY) {
-  CPDF_Type3Char* pChar = m_pFont->LoadChar(charcode);
+  const CPDF_Type3Char* pChar = m_pFont->LoadChar(charcode);
   if (pChar == NULL || pChar->m_pBitmap == NULL) {

[Tom Sepez, 2015/11/08 04:46:29]

nit: nullptr twice here and next line.

[Lei Zhang, 2015/11/09 20:27:26]

Done.

     return NULL;
   }
   CFX_DIBitmap* pBitmap = pChar->m_pBitmap;
   CFX_AffineMatrix image_matrix, text_matrix;
   image_matrix = pChar->m_ImageMatrix;
   text_matrix.Set(pMatrix->a, pMatrix->b, pMatrix->c, pMatrix->d, 0, 0);
   image_matrix.Concat(text_matrix);
   CFX_DIBitmap* pResBitmap = NULL;
   int left, top;
   if (FXSYS_fabs(image_matrix.b) < FXSYS_fabs(image_matrix.a) / 100 &&
@@ skipping 647 matching lines @@
     ProcessPath(&path, pObj2Device);
   }
 }
 
 CFX_PathData* CPDF_Font::LoadGlyphPath(FX_DWORD charcode, int dest_width) {
   int glyph_index = GlyphFromCharCode(charcode);
   if (!m_Font.GetFace())
     return nullptr;
   return m_Font.LoadGlyphPath(glyph_index, dest_width);
 }