Fix a leak in CPDF_Type3Font::LoadChar().

Fix a leak in CPDF_Type3Font::LoadChar().

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/6d9979dc685e3b67b0a6d9946376e026d75d3e47

[Lei Zhang, 2015-11-07 04:12:53]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-11-07 04:12:53]

From the bug 268 test file.

[Tom Sepez, 2015-11-08 04:46:29]

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right):

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1715: {
Why { here?  Can't you just re-assign this at 1748?

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1739: pNewChar->m_pForm = new
CPDF_Form(
Pity the constructor doesn't set m_pForm.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1778: if (charcode >
FX_ArraySize(m_CharWidthL) - 1)
or just >= and lose the -1.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1791: rect.left = rect.right = rect.top
= rect.bottom = 0;
nit: one per line.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp:132: if (pChar == NULL ||
pChar->m_pBitmap == NULL) {
nit: nullptr twice here and next line.

[Lei Zhang, 2015-11-09 20:18:29]

Patchset #2 (id:20001) has been deleted

[Lei Zhang, 2015-11-09 20:27:26]

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right):

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1715: {
On 2015/11/08 04:46:29, Tom Sepez wrote:
> Why { here?  Can't you just re-assign this at 1748?

They are unrelated so I didn't want to reuse the same variable. Let me see if I
can remove some more dead code and make this go away.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1739: pNewChar->m_pForm = new
CPDF_Form(
On 2015/11/08 04:46:29, Tom Sepez wrote:
> Pity the constructor doesn't set m_pForm.

Done.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1778: if (charcode >
FX_ArraySize(m_CharWidthL) - 1)
On 2015/11/08 04:46:29, Tom Sepez wrote:
> or just >= and lose the -1.

Done.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_font/...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1791: rect.left = rect.right = rect.top
= rect.bottom = 0;
On 2015/11/08 04:46:29, Tom Sepez wrote:
> nit: one per line.

Done.

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/1408063016/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp:132: if (pChar == NULL ||
pChar->m_pBitmap == NULL) {
On 2015/11/08 04:46:29, Tom Sepez wrote:
> nit: nullptr twice here and next line.

Done.

[Lei Zhang, 2015-11-09 20:27:56]

I have more dead code to remove. Will ping you when the CL is ready.

[Lei Zhang, 2015-11-09 21:47:41]

PTAL

[Tom Sepez, 2015-11-09 22:35:08]

lgtm

[Lei Zhang, 2015-11-09 22:47:28]

Committed patchset #3 (id:50001) manually as
6d9979dc685e3b67b0a6d9946376e026d75d3e47 (presubmit successful).