Issue 1408063015: Revert of Add text animation sample; tweak DrawShip sample

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408063015: Revert of Add text animation sample; tweak DrawShip sample (Closed)

Created:
5 years, 1 month ago by jvanverth1

Modified:
5 years, 1 month ago

Reviewers:
bsalomon, robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Add text animation sample; tweak DrawShip sample (patchset #3 id:40001 of https://codereview.chromium.org/1410663005/ ) Reason for revert: CrOS bots failing. Original issue's description: > Add text animation sample; tweak DrawShip sample > > Committed: https://skia.googlesource.com/skia/+/3b484a40b3be7f0262afadeaf6b741ba5cedcfe1 TBR=robertphillips@google.com,bsalomon@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d75ccc6a0a2eb166234d919ffd3f62ed39dd3a6e

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -207 lines)			Patch
M	gyp/SampleApp.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/gpu/GrContext.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	samplecode/SampleAnimatedText.cpp	View	1 chunk	+0 lines, -161 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	samplecode/SampleShip.cpp	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	src/gpu/GrTest.cpp	View	2 chunks	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvanverth1

Created Revert of Add text animation sample; tweak DrawShip sample

5 years, 1 month ago (2015-11-07 00:10:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408063015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408063015/1

5 years, 1 month ago (2015-11-07 00:10:27 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-07 00:10:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d75ccc6a0a2eb166234d919ffd3f62ed39dd3a6e

Expand Messages | Collapse Messages