Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: third_party/WebKit/LayoutTests/animations/animations-parsing.html

Issue 1408063004: Parse animation and transition shorthands in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@anim4
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/animations/animations-parsing.html
diff --git a/third_party/WebKit/LayoutTests/animations/animations-parsing.html b/third_party/WebKit/LayoutTests/animations/animations-parsing.html
index 05d7ed56d31f47ec6aef6c54e068cd4d0fa01ac4..76953290b6c2d90e18d0f431eafe11f2b180eb28 100644
--- a/third_party/WebKit/LayoutTests/animations/animations-parsing.html
+++ b/third_party/WebKit/LayoutTests/animations/animations-parsing.html
@@ -1079,6 +1079,36 @@ shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");
shouldBe("style.webkitAnimation", "''");
shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none running'");
+style.animation = ",";
+shouldBe("style.animation", "''");
+shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");
+shouldBe("style.webkitAnimation", "''");
+shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none running'");
+
+style.animation = "running,";
+shouldBe("style.animation", "''");
+shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");
+shouldBe("style.webkitAnimation", "''");
+shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none running'");
+
+style.animation = ", alternate";
+shouldBe("style.animation", "''");
+shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");
+shouldBe("style.webkitAnimation", "''");
+shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none running'");
+
+style.animation = ", commas,";
+shouldBe("style.animation", "''");
+shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");
+shouldBe("style.webkitAnimation", "''");
+shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none running'");
+
+style.animation = "test,, 5s";
+shouldBe("style.animation", "''");
+shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");
+shouldBe("style.webkitAnimation", "''");
+shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none running'");
rwlbuis 2015/10/20 14:32:23 Do these extra test passes mean the behavior has i
Timothy Loh 2015/10/21 06:07:39 It's already mentioned there. The last added test
+
// FIXME : https://code.google.com/p/chromium/issues/detail?id=273092
/*style.animation = "ease-in ease-otu 5s";
shouldBe("style.animation", "''");

Powered by Google App Engine
This is Rietveld 408576698