third_party/WebKit/LayoutTests/animations/animations-parsing.html - Issue 1408063004: Parse animation and transition shorthands in CSSPropertyParser with CSSParserTokens

Side by Side Diff: third_party/WebKit/LayoutTests/animations/animations-parsing.html

Issue 1408063004: Parse animation and transition shorthands in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@anim4

Patch Set: rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/animations/animations-parsing-expected.txt » ('j') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7 <script>	7 <script>

8 description("Test the parsing and the computed style values of the animations pr operties.")	8 description("Test the parsing and the computed style values of the animations pr operties.")

9	9

10 var testContainer = document.createElement("div");	10 var testContainer = document.createElement("div");

(...skipping 1061 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1072 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");	1072 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

1073 shouldBe("style.webkitAnimation", "''");	1073 shouldBe("style.webkitAnimation", "''");

1074 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");	1074 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");

1075	1075

1076 style.animation = "none, ease-in opacity 20s 10s myAnim";	1076 style.animation = "none, ease-in opacity 20s 10s myAnim";

1077 shouldBe("style.animation", "''");	1077 shouldBe("style.animation", "''");

1078 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");	1078 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

1079 shouldBe("style.webkitAnimation", "''");	1079 shouldBe("style.webkitAnimation", "''");

1080 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");	1080 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");

1081	1081

	1082 style.animation = ",";

	1083 shouldBe("style.animation", "''");

	1084 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

	1085 shouldBe("style.webkitAnimation", "''");

	1086 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");

	1087

	1088 style.animation = "running,";

	1089 shouldBe("style.animation", "''");

	1090 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

	1091 shouldBe("style.webkitAnimation", "''");

	1092 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");

	1093

	1094 style.animation = ", alternate";

	1095 shouldBe("style.animation", "''");

	1096 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

	1097 shouldBe("style.webkitAnimation", "''");

	1098 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");

	1099

	1100 style.animation = ", commas,";

	1101 shouldBe("style.animation", "''");

	1102 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

	1103 shouldBe("style.webkitAnimation", "''");

	1104 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");

	1105

	1106 style.animation = "test,, 5s";

	1107 shouldBe("style.animation", "''");

	1108 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

	1109 shouldBe("style.webkitAnimation", "''");

	1110 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");
	rwlbuis 2015/10/20 14:32:23 Do these extra test passes mean the behavior has i Do these extra test passes mean the behavior has improved? If so you may want to mention it in the commit message. Timothy Loh 2015/10/21 06:07:39 It's already mentioned there. The last added test Show quoted text On 2015/10/20 14:32:23, rwlbuis wrote: > Do these extra test passes mean the behavior has improved? If so you may want to > mention it in the commit message. It's already mentioned there. The last added test here is the only one that currently works.
	1111

1082 // FIXME : https://code.google.com/p/chromium/issues/detail?id=273092	1112 // FIXME : https://code.google.com/p/chromium/issues/detail?id=273092

1083 /*style.animation = "ease-in ease-otu 5s";	1113 /*style.animation = "ease-in ease-otu 5s";

1084 shouldBe("style.animation", "''");	1114 shouldBe("style.animation", "''");

1085 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");	1115 shouldBe("computedStyle.animation", "'none 0s ease 0s 1 normal none running'");

1086 shouldBe("style.webkitAnimation", "''");	1116 shouldBe("style.webkitAnimation", "''");

1087 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");*/	1117 shouldBe("computedStyle.webkitAnimation", "'none 0s ease 0s 1 normal none runnin g'");*/

1088	1118

1089 document.body.removeChild(testContainer);	1119 document.body.removeChild(testContainer);

1090 </script>	1120 </script>

1091 </body>	1121 </body>

1092 </html>	1122 </html>

OLD	NEW