pkg/compiler/lib/src/native/ssa.dart - Issue 1408043002: Move native and js interop properties from the element model to the JS backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/native/ssa.dart

Issue 1408043002: Move native and js interop properties from the element model to the JS backend (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Cleanup Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('K') | « pkg/compiler/lib/src/native/scanner.dart ('k') | pkg/compiler/lib/src/parser/diet_parser_task.dart » ('j') | pkg/compiler/lib/src/parser/element_listener.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/native/ssa.dart

diff --git a/pkg/compiler/lib/src/native/ssa.dart b/pkg/compiler/lib/src/native/ssa.dart

index 1dfa53616256d96f4127c221e2fb30190e2455ba..b51c64d3bb477230981958953f271bb8ead18334 100644

--- a/pkg/compiler/lib/src/native/ssa.dart

+++ b/pkg/compiler/lib/src/native/ssa.dart

@@ -35,8 +35,8 @@ void handleSsaNative(SsaBuilder builder, Expression nativeBody) {

// 3) foo() native "return 42";

// hasBody = true

bool hasBody = false;

- assert(element.isNative);

- String nativeMethodName = element.fixedBackendName;

+ assert(backend.isNative(element));

+ String nativeMethodName = backend.getFixedBackendName(element);

if (nativeBody != null) {

LiteralString jsCode = nativeBody.asLiteralString();

String str = jsCode.dartString.slowToString();