pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart - Issue 1408043002: Move native and js interop properties from the element model to the JS backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

Issue 1408043002: Move native and js interop properties from the element model to the JS backend (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Cleanup Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/backend.dart ('K') | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | pkg/compiler/lib/src/library_loader.dart » ('j') | pkg/compiler/lib/src/parser/element_listener.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

index 8b20e2de9d3e8117878785ec9eceeb5a282d0d4a..cdfe0094fb703788e1a75a59af531c090facb0de 100644

--- a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

@@ -68,7 +68,8 @@ class RuntimeTypeGenerator {

/// native classes.

/// TODO(herhut): Generate tests for native classes dynamically, as well.

void generateIsTest(Element other) {

- if (classElement.isJsInterop || classElement.isNative ||

+ if (backend.isJsInterop(classElement) ||

Jacob 2015/10/16 17:02:18 nt your fault but isJsInterop imples isNative so r

Johnni Winther 2015/10/22 09:06:03 Done.

+ backend.isNative(classElement) ||

!classElement.isSubclassOf(other)) {

result.properties[namer.operatorIs(other)] = js('1');

}