Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issue 1408033010: Fix for Exit Fullscreen Animation (Closed)

Created:
5 years, 1 month ago by spqchan
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for the exit fullscreen animation so that it is more smooth in 10.10+. This CL changes the approach for exiting fullscreen animation so that resizes the content view instead of the layer. As a result, some of the old hacks are also removed in this CL. In addition, the fullscreen animation's duration is shortened to create a faster transition. BUG=530801, 549063 Committed: https://crrev.com/207a1ee1b1715f34d5435b604e287cf4f816a8e7 Cr-Commit-Position: refs/heads/master@{#358906}

Patch Set 1 #

Patch Set 2 : Fixed a few bugs #

Patch Set 3 : Refactored the code. Removed the hacks that are no longer neccessary. #

Patch Set 4 : Limit the availability of custom animations #

Patch Set 5 : Decrease the duration of the animation and disable the exit animation on 10.9 #

Patch Set 6 : Fix comments #

Total comments: 20

Patch Set 7 : #

Patch Set 8 : Updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -64 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 2 3 4 5 6 7 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_fullscreen_transition.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_fullscreen_transition.mm View 1 2 3 4 5 6 12 chunks +145 lines, -26 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.h View 1 2 4 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/framed_browser_window.mm View 1 2 3 4 5 6 3 chunks +3 lines, -13 lines 0 comments Download
M chrome/browser/ui/cocoa/full_size_content_window.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/full_size_content_window.mm View 4 3 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
spqchan
PTAL
5 years, 1 month ago (2015-11-07 03:09:53 UTC) #6
erikchen
https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm#newcode1116 chrome/browser/ui/cocoa/browser_window_controller_private.mm:1116: if (base::mac::IsOSMavericks() && !enterFullScreen) Why? Add a link to ...
5 years, 1 month ago (2015-11-09 18:29:21 UTC) #7
spqchan
PTAL https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm#newcode1116 chrome/browser/ui/cocoa/browser_window_controller_private.mm:1116: if (base::mac::IsOSMavericks() && !enterFullScreen) On 2015/11/09 18:29:21, erikchen ...
5 years, 1 month ago (2015-11-09 22:27:19 UTC) #8
erikchen
lgtm with nits https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm#newcode1116 chrome/browser/ui/cocoa/browser_window_controller_private.mm:1116: if (base::mac::IsOSMavericks() && !enterFullScreen) On 2015/11/09 ...
5 years, 1 month ago (2015-11-10 02:15:44 UTC) #10
spqchan
PTAL https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm#newcode1116 chrome/browser/ui/cocoa/browser_window_controller_private.mm:1116: if (base::mac::IsOSMavericks() && !enterFullScreen) On 2015/11/10 02:15:43, erikchen ...
5 years, 1 month ago (2015-11-10 18:45:31 UTC) #11
erikchen
On 2015/11/10 18:45:31, spqchan wrote: > PTAL > > https://codereview.chromium.org/1408033010/diff/100001/chrome/browser/ui/cocoa/browser_window_controller_private.mm > File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right): > ...
5 years, 1 month ago (2015-11-10 18:48:02 UTC) #12
erikchen
On 2015/11/10 18:48:02, erikchen wrote: > On 2015/11/10 18:45:31, spqchan wrote: > > PTAL > ...
5 years, 1 month ago (2015-11-10 18:48:35 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408033010/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408033010/140001
5 years, 1 month ago (2015-11-10 19:34:09 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 20:05:33 UTC) #17
spqchan
+avi for LGTM stamp
5 years, 1 month ago (2015-11-10 21:19:54 UTC) #20
Avi (use Gerrit)
lgtm stampity stamp
5 years, 1 month ago (2015-11-10 21:23:23 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408033010/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408033010/140001
5 years, 1 month ago (2015-11-10 21:24:56 UTC) #23
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 1 month ago (2015-11-10 21:30:54 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 21:31:43 UTC) #25
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/207a1ee1b1715f34d5435b604e287cf4f816a8e7
Cr-Commit-Position: refs/heads/master@{#358906}

Powered by Google App Engine
This is Rietveld 408576698