Fix for Exit Fullscreen Animation

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #import "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 1090 matching lines @@
     return NO;
   if (!enteringAppKitFullscreen_)
     return NO;
   if (enteringAppKitFullscreenOnPrimaryScreen_)
     return NO;
 
   return YES;
 }
 
 - (BOOL)shouldUseCustomAppKitFullscreenTransition:(BOOL)enterFullScreen {
-  // We are temporary disabling exit fullscreen animation because it only
-  // works on OSX 10.10.
-  // TODO(spqchan): Fix exit fullscreen animation so that it works on all
-  // OSX versions.
-  if (!enterFullScreen)
-    return NO;
-
+  // Custom fullscreen transitions should only be available in OSX 10.10+.
   if (base::mac::IsOSMountainLionOrEarlier())
     return NO;
 
+  // Disable the custom exit animation in OSX 10.9.
+  if (base::mac::IsOSMavericks() && !enterFullScreen)

[erikchen, 2015/11/09 18:29:21]

Why? Add a link to a crbug post or add more details here.

[spqchan, 2015/11/09 22:27:19]

Done.

[erikchen, 2015/11/10 02:15:43]

Use the link: 
https://code.google.com/p/chromium/issues/detail?id=526327#c3

[spqchan, 2015/11/10 18:45:31]

Done.

+    return NO;
+
   NSView* root = [[self.window contentView] superview];
   if (!root.layer)
     return NO;
 
   // AppKit on OSX 10.9 has a bug for applications linked against OSX 10.8 SDK
   // and earlier. Under specific circumstances, it prevents the custom AppKit
   // transition from working well. See http://crbug.com/396980 for more
   // details.
   if ([[self class] systemSettingsRequireMavericksAppKitFullscreenHack] &&
       ![[[self window] screen] isEqual:[[NSScreen screens] firstObject]]) {
@@ skipping 18 matching lines @@
 
 - (NSArray*)customWindowsToExitFullScreenForWindow:(NSWindow*)window {
   DCHECK([window isEqual:self.window]);
 
   if (![self shouldUseCustomAppKitFullscreenTransition:NO])
     return nil;
 
   FramedBrowserWindow* framedBrowserWindow =
       base::mac::ObjCCast<FramedBrowserWindow>([self window]);
   fullscreenTransition_.reset([[BrowserWindowFullscreenTransition alloc]
-      initExitWithWindow:framedBrowserWindow
-                   frame:savedRegularWindowFrame_]);
+          initExitWithWindow:framedBrowserWindow
+                       frame:savedRegularWindowFrame_
+      tabStripBackgroundView:[self tabStripBackgroundView]]);
 
   return [fullscreenTransition_ customWindowsForFullScreenTransition];
 }
 
 - (void)window:(NSWindow*)window
     startCustomAnimationToEnterFullScreenWithDuration:(NSTimeInterval)duration {
   DCHECK([window isEqual:self.window]);
   [fullscreenTransition_ startCustomFullScreenAnimationWithDuration:duration];
 
   base::AutoReset<BOOL> autoReset(&blockLayoutSubviews_, NO);
@@ skipping 21 matching lines @@
   return browser_->tab_strip_model()->GetActiveWebContents();
 }
 
 - (PermissionBubbleManager*)permissionBubbleManager {
   if (WebContents* contents = [self webContents])
     return PermissionBubbleManager::FromWebContents(contents);
   return nil;
 }
 
 @end  // @implementation BrowserWindowController(Private)