Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 1408003013: Reland "EDK: Move //mojo/edk/system/waitable_event* to edk/util." (Closed)

Created:
5 years, 1 month ago by viettrungluu
Modified:
5 years, 1 month ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Reland "EDK: Move //mojo/edk/system/waitable_event* to edk/util." (This reverts commit dd010e1297c09b351dc82f7def154cfa63d795b1, and relands commit c079879fb71164876098efae585c4adb37ca1315.) We need to do some Mac-/iOS-specific things for mojo::util::WaitableEvent (which needs to get a monotonic clock). I haven't tested this on Mac or iOS -- it's basically cargo culted from Chromium, with some extra modifications (to make it extra risky). I'll try to verify that they work separately, but at least this works on Linux and Android. R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/9a32daa8803a72c665cac470876f3a58262cc1ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -649 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/edk/system/channel_endpoint_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/dispatcher_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/endpoint_relayer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/system/master_connection_manager.h View 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/master_connection_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/raw_channel_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/edk/system/slave_connection_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/test/test_io_thread.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/test/test_io_thread.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.h View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/edk/system/test_channel_endpoint_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
D mojo/edk/system/waitable_event.h View 1 chunk +0 lines, -127 lines 0 comments Download
D mojo/edk/system/waitable_event.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D mojo/edk/system/waitable_event_unittest.cc View 1 chunk +0 lines, -257 lines 0 comments Download
M mojo/edk/util/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/edk/util/cond_var_unittest.cc View 7 chunks +13 lines, -10 lines 0 comments Download
M mojo/edk/util/mutex_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/edk/util/ref_counted_perftest.cc View 3 chunks +11 lines, -8 lines 0 comments Download
A + mojo/edk/util/waitable_event.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + mojo/edk/util/waitable_event.cc View 7 chunks +68 lines, -17 lines 0 comments Download
A + mojo/edk/util/waitable_event_unittest.cc View 15 chunks +31 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 1 month ago (2015-11-06 22:55:06 UTC) #1
vardhan
lgtm
5 years, 1 month ago (2015-11-06 23:09:35 UTC) #2
viettrungluu
Committed patchset #1 (id:1) manually as 9a32daa8803a72c665cac470876f3a58262cc1ad (presubmit successful).
5 years, 1 month ago (2015-11-06 23:24:45 UTC) #3
viettrungluu
5 years, 1 month ago (2015-11-06 23:24:59 UTC) #4
Message was sent while issue was closed.
On 2015/11/06 23:09:35, vardhan wrote:
> lgtm

Thanks. FYI, I checked and it even works (at least on Mac).

Powered by Google App Engine
This is Rietveld 408576698