Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1407993003: win: Fix crashpad_util_test ProcessInfo.Handles (Closed)

Created:
5 years, 2 months ago by Mark Mentovai
Modified:
5 years, 2 months ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Fix crashpad_util_test ProcessInfo.Handles This new test from 7de04b02f85d was failing on Windows 10. I started by adding the hint, which produced “CreateFileMapping: Access is denied. (0x5)”. Switching the “Global\” to “Local\” fixes the test for me. TEST=crashpad_util_test ProcessInfo.Handles R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1818dbbb0851527281a281622b36a742664baa3f

Patch Set 1 #

Patch Set 2 : Use Local\ instead of Global\ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M util/win/process_info_test.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
Based on https://msdn.microsoft.com/en-us/library/windows/desktop/aa366537(v=vs.85).aspx, I’m led to believe that I must not have “the SeCreateGlobalPrivilege privilege”. ...
5 years, 2 months ago (2015-10-17 02:36:50 UTC) #2
scottmg
On 2015/10/17 02:36:50, Mark Mentovai wrote: > Based on > https://msdn.microsoft.com/en-us/library/windows/desktop/aa366537(v=vs.85).aspx, > I’m led to ...
5 years, 2 months ago (2015-10-19 17:30:32 UTC) #3
Mark Mentovai
It’s a pretty standard VM, so I’m not sure what happened.
5 years, 2 months ago (2015-10-19 17:32:09 UTC) #4
Mark Mentovai
5 years, 2 months ago (2015-10-19 17:40:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1818dbbb0851527281a281622b36a742664baa3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698