Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: util/win/process_info_test.cc

Issue 1407993003: win: Fix crashpad_util_test ProcessInfo.Handles (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Use Local\ instead of Global\ Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/process_info_test.cc
diff --git a/util/win/process_info_test.cc b/util/win/process_info_test.cc
index 4a8a209fd988c44ca51e338ffd5828245eb77ad6..925d0062273b0f9e55361b91803092d9723565da 100644
--- a/util/win/process_info_test.cc
+++ b/util/win/process_info_test.cc
@@ -25,6 +25,7 @@
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "gtest/gtest.h"
+#include "test/errors.h"
#include "test/scoped_temp_dir.h"
#include "test/paths.h"
#include "test/win/child_launcher.h"
@@ -553,7 +554,7 @@ TEST(ProcessInfo, Handles) {
ASSERT_TRUE(scoped_key.is_valid());
std::wstring mapping_name =
- base::UTF8ToUTF16(base::StringPrintf("Global\\test_mapping_%d_%I64x",
+ base::UTF8ToUTF16(base::StringPrintf("Local\\test_mapping_%d_%I64x",
GetCurrentProcessId(),
base::RandUint64()));
ScopedKernelHANDLE mapping(CreateFileMapping(INVALID_HANDLE_VALUE,
@@ -562,7 +563,7 @@ TEST(ProcessInfo, Handles) {
0,
1024,
mapping_name.c_str()));
- ASSERT_TRUE(mapping.is_valid());
+ ASSERT_TRUE(mapping.is_valid()) << ErrorMessage("CreateFileMapping");
ProcessInfo info;
info.Initialize(GetCurrentProcess());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698