Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407953011: Re-land: Removed virtualenv from depot_tools (Closed)

Created:
5 years, 1 month ago by Sergiy Byelozyorov
Modified:
5 years, 1 month ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : Original CL #

Patch Set 2 : Re-added files that were present before virtualenv #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6628 lines) Patch
M .gitignore View 1 chunk +0 lines, -3 lines 0 comments Download
M PRESUBMIT.py View 1 chunk +1 line, -2 lines 0 comments Download
D bootstrap/.gitignore View 1 chunk +0 lines, -2 lines 0 comments Download
D bootstrap/bootstrap.py View 1 chunk +0 lines, -234 lines 0 comments Download
D bootstrap/deps.pyl View 1 chunk +0 lines, -15 lines 0 comments Download
D bootstrap/util.py View 1 chunk +0 lines, -87 lines 0 comments Download
D bootstrap/virtualenv/.gitignore View 1 chunk +0 lines, -10 lines 0 comments Download
D bootstrap/virtualenv/.travis.yml View 1 chunk +0 lines, -28 lines 0 comments Download
D bootstrap/virtualenv/AUTHORS.txt View 1 chunk +0 lines, -91 lines 0 comments Download
D bootstrap/virtualenv/CONTRIBUTING.rst View 1 chunk +0 lines, -21 lines 0 comments Download
D bootstrap/virtualenv/LICENSE.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D bootstrap/virtualenv/MANIFEST.in View 1 chunk +0 lines, -11 lines 0 comments Download
D bootstrap/virtualenv/README.rst View 1 chunk +0 lines, -10 lines 0 comments Download
D bootstrap/virtualenv/bin/rebuild-script.py View 1 chunk +0 lines, -71 lines 0 comments Download
D bootstrap/virtualenv/docs/Makefile View 1 chunk +0 lines, -130 lines 0 comments Download
D bootstrap/virtualenv/docs/changes.rst View 1 chunk +0 lines, -747 lines 0 comments Download
D bootstrap/virtualenv/docs/conf.py View 1 chunk +0 lines, -149 lines 0 comments Download
D bootstrap/virtualenv/docs/development.rst View 1 chunk +0 lines, -61 lines 0 comments Download
D bootstrap/virtualenv/docs/index.rst View 1 chunk +0 lines, -137 lines 0 comments Download
D bootstrap/virtualenv/docs/installation.rst View 1 chunk +0 lines, -58 lines 0 comments Download
D bootstrap/virtualenv/docs/make.bat View 1 chunk +0 lines, -170 lines 0 comments Download
D bootstrap/virtualenv/docs/reference.rst View 1 chunk +0 lines, -256 lines 0 comments Download
D bootstrap/virtualenv/docs/userguide.rst View 1 chunk +0 lines, -249 lines 0 comments Download
D bootstrap/virtualenv/scripts/virtualenv View 1 chunk +0 lines, -3 lines 0 comments Download
D bootstrap/virtualenv/setup.py View 1 chunk +0 lines, -111 lines 0 comments Download
D bootstrap/virtualenv/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D bootstrap/virtualenv/tests/test_activate.sh View 1 chunk +0 lines, -94 lines 0 comments Download
D bootstrap/virtualenv/tests/test_activate_expected.output View 1 chunk +0 lines, -2 lines 0 comments Download
D bootstrap/virtualenv/tests/test_virtualenv.py View 1 chunk +0 lines, -139 lines 0 comments Download
D bootstrap/virtualenv/tests/tox.ini View 1 chunk +0 lines, -12 lines 0 comments Download
D bootstrap/virtualenv/tox.ini View 1 chunk +0 lines, -17 lines 0 comments Download
D bootstrap/virtualenv/virtualenv.py View 1 chunk +0 lines, -2367 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.bat View 1 chunk +0 lines, -26 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.csh View 1 chunk +0 lines, -42 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.fish View 1 chunk +0 lines, -74 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.ps1 View 1 chunk +0 lines, -150 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate.sh View 1 chunk +0 lines, -80 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/activate_this.py View 1 chunk +0 lines, -34 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/deactivate.bat View 1 chunk +0 lines, -20 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/distutils.cfg View 1 chunk +0 lines, -6 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/distutils-init.py View 1 chunk +0 lines, -101 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_embedded/site.py View 1 chunk +0 lines, -758 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_support/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
D bootstrap/virtualenv/virtualenv_support/pip-6.0-py2.py3-none-any.whl View Binary file 0 comments Download
D bootstrap/virtualenv/virtualenv_support/setuptools-8.2.1-py2.py3-none-any.whl View Binary file 0 comments Download
M commit_queue View 1 chunk +1 line, -5 lines 0 comments Download
M commit_queue.bat View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/cq_client/cq_pb2.py View 1 chunk +13 lines, -5 lines 0 comments Download
M third_party/cq_client/validate_config.py View 1 chunk +8 lines, -1 line 0 comments Download
M third_party/protobuf26/README.chromium View 2 chunks +9 lines, -6 lines 0 comments Download
M update_depot_tools View 1 chunk +0 lines, -4 lines 0 comments Download
M update_depot_tools.bat View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Sergiy Byelozyorov
5 years, 1 month ago (2015-11-09 19:10:28 UTC) #1
tandrii(chromium)
rs-lgtm, but it's not valid without dnj's one.
5 years, 1 month ago (2015-11-09 19:15:04 UTC) #2
dnj (Google)
rs-lgtm, looks like it leaves Windows bootstrap code alone. Deferring to tandrii@ for the virtualenv ...
5 years, 1 month ago (2015-11-09 19:17:23 UTC) #4
Sergiy Byelozyorov
5 years, 1 month ago (2015-11-09 19:20:59 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 297494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698