Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: third_party/cq_client/validate_config.py

Issue 1407953011: Re-land: Removed virtualenv from depot_tools (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Re-added files that were present before virtualenv Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « third_party/cq_client/cq_pb2.py ('k') | third_party/protobuf26/README.chromium » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """CQ config validation library.""" 6 """CQ config validation library."""
7 7
8 import argparse 8 import argparse
9 from google import protobuf 9 # This file was originally copied together with the cq_client library from the
10 # internal commit_queue repository and then modified to import protobuf26
11 # instead of google.protobuf to prevent conflicts with a different version of
12 # google.protobuf that some users of depot_tools have installed. If you need to
13 # update this file, please make similar changes again and add this comment back.
14 # More details on why we chose to rename the package can be found in the file
15 # depot_tools/third_party/protobuf26/README.chromium.
16 import protobuf26 as protobuf
10 import logging 17 import logging
11 import re 18 import re
12 import sys 19 import sys
13 20
14 from cq_client import cq_pb2 21 from cq_client import cq_pb2
15 22
16 23
17 REQUIRED_FIELDS = [ 24 REQUIRED_FIELDS = [
18 'version', 25 'version',
19 'rietveld', 26 'rietveld',
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 try: 106 try:
100 re.compile(base) 107 re.compile(base)
101 except re.error: 108 except re.error:
102 logging.error('failed to parse "%s" in project_bases as a regexp', base) 109 logging.error('failed to parse "%s" in project_bases as a regexp', base)
103 return False 110 return False
104 111
105 # TODO(sergiyb): For each field, check valid values depending on its 112 # TODO(sergiyb): For each field, check valid values depending on its
106 # semantics, e.g. email addresses, regular expressions etc. 113 # semantics, e.g. email addresses, regular expressions etc.
107 114
108 return True 115 return True
OLDNEW
« no previous file with comments | « third_party/cq_client/cq_pb2.py ('k') | third_party/protobuf26/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698