Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Issue 1407933008: Revert "mac: Run A/B experiment on SharedMemory mechanism for resource buffers." (Closed)

Created:
5 years, 1 month ago by Elly Fong-Jones
Modified:
5 years, 1 month ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org, jam, gavinp+memory_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, loading-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "mac: Run A/B experiment on SharedMemory mechanism for resource buffers." This reverts commit e0e2fd398f3d07c8eebbe662d71a0f9286862476. I believe this CL introduced these layout test failures: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Oilpan/builds/25790 BUG=None TBR=erikchen Committed: https://crrev.com/522380f2260a57c43f1f9296560c3f641a35e9c6 Cr-Commit-Position: refs/heads/master@{#356557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M base/memory/shared_memory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/memory/shared_memory_handle.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 4 chunks +0 lines, -31 lines 0 comments Download
M content/browser/loader/resource_buffer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407933008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407933008/1
5 years, 1 month ago (2015-10-28 13:26:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 15:21:59 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/522380f2260a57c43f1f9296560c3f641a35e9c6 Cr-Commit-Position: refs/heads/master@{#356557}
5 years, 1 month ago (2015-10-28 15:22:48 UTC) #5
chromium-reviews
5 years, 1 month ago (2015-10-28 15:25:30 UTC) #6
Message was sent while issue was closed.
Are there any stack traces from the layout test crashes?

On Wed, Oct 28, 2015 at 11:22 AM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/522380f2260a57c43f1f9296560c3f641a35e9c6
> Cr-Commit-Position: refs/heads/master@{#356557}
>
> https://codereview.chromium.org/1407933008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698