Plugin Power Saver: Fix play-icon positioning when poster specified.

Plugin Power Saver: Fix play-icon positioning when poster specified.

A bug slipped through about play-icon positioning when the poster attribute is specified for Plugin Power Saver.

Probably when we made last minute fixes for tiny plugins.

BUG=543354
TEST=Manually verify with http://pps-test-a.appspot.com/combined.html

Committed: https://crrev.com/2d2a5b924948188588006e29dc88771f862c66e6
Cr-Commit-Position: refs/heads/master@{#354640}

[tommycli, 2015-10-15 21:51:14]

tommycli@chromium.org changed reviewers:
+ thestig@chromium.org

[tommycli, 2015-10-15 21:54:51]

thestig: PTAL

This fixes 50% of the problems for the comedians in cars video page.

https://codereview.chromium.org/1407913002/diff/40001/components/plugins/rend...
File components/plugins/renderer/loadable_plugin_placeholder.cc (right):

https://codereview.chromium.org/1407913002/diff/40001/components/plugins/rend...
components/plugins/renderer/loadable_plugin_placeholder.cc:347: if
(premade_throttler_ &&
Needed to compensate for change in line 187.

[Lei Zhang, 2015-10-15 22:58:25]

Do you think it's possible to add a test?

[Lei Zhang, 2015-10-15 23:05:31]

https://codereview.chromium.org/1407913002/diff/40001/components/plugins/rend...
File components/plugins/renderer/loadable_plugin_placeholder.cc (right):

https://codereview.chromium.org/1407913002/diff/40001/components/plugins/rend...
components/plugins/renderer/loadable_plugin_placeholder.cc:347: if
(premade_throttler_ &&
On 2015/10/15 21:54:50, tommycli wrote:
> Needed to compensate for change in line 187.

Sorry, it's been a while. You'll have to remind me why we need the line 187
change. Maybe in person.

[tommycli, 2015-10-16 17:16:25]

thestig:

Hey. I think it would be really tough to write a test here actually, as the test
would have to answer: Is the play button perceptually within the middle of the
visible portion of the SWF.

I hope the manual test page I showed you was sufficient.

https://codereview.chromium.org/1407913002/diff/40001/components/plugins/rend...
File components/plugins/renderer/loadable_plugin_placeholder.cc (right):

https://codereview.chromium.org/1407913002/diff/40001/components/plugins/rend...
components/plugins/renderer/loadable_plugin_placeholder.cc:347: if
(premade_throttler_ &&
On 2015/10/15 23:05:31, Lei Zhang wrote:
> On 2015/10/15 21:54:50, tommycli wrote:
> > Needed to compensate for change in line 187.
> 
> Sorry, it's been a while. You'll have to remind me why we need the line 187
> change. Maybe in person.

Discussed in person.

[Lei Zhang, 2015-10-16 19:11:55]

On 2015/10/16 17:16:25, tommycli wrote:
> thestig:
> 
> Hey. I think it would be really tough to write a test here actually, as the
test
> would have to answer: Is the play button perceptually within the middle of the
> visible portion of the SWF.
> 
> I hope the manual test page I showed you was sufficient.

Do you want to try to go the layout test route and do some pixel testing? If the
poster is simple enough, it's just a set pattern with a play button in the
middle. That should not require too much adjustment going forward... I hope.

[Lei Zhang, 2015-10-16 22:17:27]

lgtm

Tests will have to be another day...

[tommycli, 2015-10-16 22:17:46]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2015-10-16 22:18:02]

On 2015/10/16 22:17:27, Lei Zhang wrote:
> lgtm
> 
> Tests will have to be another day...

Bug to complete tests:
https://code.google.com/p/chromium/issues/detail?id=544292

[commit-bot: I haz the power, 2015-10-16 22:18:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407913002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407913002/40001

[commit-bot: I haz the power, 2015-10-16 23:41:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-16 23:42:39]

Patchset 3 (id:??) landed as
https://crrev.com/2d2a5b924948188588006e29dc88771f862c66e6
Cr-Commit-Position: refs/heads/master@{#354640}