Add new experimental IDBObjectStore.getKey(query) API

Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discussion
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey

Committed: https://crrev.com/1e5f0bc7ac92517bd79bee8b53dbdc894f5798f5
Cr-Commit-Position: refs/heads/master@{#415047}

[jsbell, 2016-08-26 19:05:16]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 19:05:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2016-08-26 19:06:49]

jsbell@chromium.org changed reviewers:
+ cmumford@chromium.org

[jsbell, 2016-08-26 19:06:50]

cmumford@ - Firefox has gone ahead and implemented this so we might as well.

Please take a look?

[commit-bot: I haz the power, 2016-08-26 21:10:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:10:09]

Dry run: This issue passed the CQ dry run.

[jsbell, 2016-08-26 23:30:42]

Description was changed from

==========
Add new experimental IDBObjectStore.getKey(query) API

For symmetry with IDBIndex.getKey(). When probing for existence this
is avoids the deserialization and cursor overhead and identifies a
specific key in a range, which are drawbacks to get(), count(), or
openKeyCursor().

Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

to

==========
Add new experimental IDBObjectStore.getKey(query) API

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/LNvvdSbgAqw/WB...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

[jsbell, 2016-08-26 23:30:58]

Description was changed from

==========
Add new experimental IDBObjectStore.getKey(query) API

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/LNvvdSbgAqw/WB...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

to

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/LNvvdSbgAqw/WB...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

[cmumford, 2016-08-29 18:28:36]

On 2016/08/26 19:06:50, jsbell wrote:
> cmumford@ - Firefox has gone ahead and implemented this so we might as well.
> 
> Please take a look?

Still reviewing, but you probably want the Intent to Implement to link to the
full discussion:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discus...

[jsbell, 2016-08-29 18:33:54]

Description was changed from

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/LNvvdSbgAqw/WB...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

to

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LNvvdSbgAqw/9AN1w9sc...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

[jsbell, 2016-08-29 18:36:28]

Description was changed from

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/LNvvdSbgAqw/9AN1w9sc...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

to

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discus...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

[jsbell, 2016-08-29 18:37:01]

On 2016/08/29 18:28:36, cmumford wrote:
> Still reviewing, but you probably want the Intent to Implement to link to the
> full discussion:

Updated - can you double check, since apparently my copy/paste skills are weak?

[cmumford, 2016-08-29 19:03:23]

lgtm % nit.

https://codereview.chromium.org/1407883002/diff/60001/content/browser/indexed...
File content/browser/indexed_db/indexed_db_database.cc (right):

https://codereview.chromium.org/1407883002/diff/60001/content/browser/indexed...
content/browser/indexed_db/indexed_db_database.cc:968:
callbacks->OnSuccess(*key);
Indenting is wrong.

[jsbell, 2016-08-29 19:12:37]

The CQ bit was checked by jsbell@chromium.org

[jsbell, 2016-08-29 19:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
cmumford@chromium.org
Link to the patchset: https://codereview.chromium.org/1407883002/#ps80001
(title: "git cl format")

[commit-bot: I haz the power, 2016-08-29 19:31:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:22:39]

Description was changed from

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discus...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

to

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discus...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

[commit-bot: I haz the power, 2016-08-30 03:22:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-30 03:25:13]

Description was changed from

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discus...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey
==========

to

==========
Add IDBObjectStore.getKey(query) API (experimental)

When probing for existence this avoids the deserialization
and cursor overhead and identifies a specific key in a range,
which are drawbacks to get(), count(), or openKeyCursor().
Also makes the store and index query APIs the same shape.

Intent to Implement:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/LNvvdSbgAqw/discus...
Spec: https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getkey

Committed: https://crrev.com/1e5f0bc7ac92517bd79bee8b53dbdc894f5798f5
Cr-Commit-Position: refs/heads/master@{#415047}
==========

[commit-bot: I haz the power, 2016-08-30 03:25:14]

Patchset 5 (id:??) landed as
https://crrev.com/1e5f0bc7ac92517bd79bee8b53dbdc894f5798f5
Cr-Commit-Position: refs/heads/master@{#415047}