Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: components/flags_ui/resources/flags.html

Issue 1407753002: Clean up terminology used in about_flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment on FeatureEntry. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/flags_ui/resources/flags.css ('k') | components/flags_ui/resources/flags.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/flags_ui/resources/flags.html
diff --git a/components/flags_ui/resources/flags.html b/components/flags_ui/resources/flags.html
index 3772f465ce96539986c3cd9c4a66be658a511e7d..08e74a5b477d582597b364ab3c1d7f8da17cf9b3 100644
--- a/components/flags_ui/resources/flags.html
+++ b/components/flags_ui/resources/flags.html
@@ -39,7 +39,7 @@
</div>
</if>
- <div id="flagsExperimentTemplate">
+ <div id="flagsTemplate">
<div id="container" class="vbox-container">
<div id="top" class="wbox">
<div class="section-header">
@@ -56,15 +56,9 @@
</div>
<div class="content">
- <div class="experiment-name no-experiments"
- jsdisplay="supportedExperiments.length == 0">
- <div i18n-content="flagsNoExperimentsAvailable"
- >NO_EXPERIMENTS_ARE_AVAILABLE</div>
- </div>
-
- <div jsdisplay="supportedExperiments.length > 0">
+ <div jsdisplay="supportedFeatures.length > 0">
James Hawkins 2015/10/14 20:34:40 What is the point of this div? It also appears to
Alexei Svitkine (slow) 2015/10/14 20:58:42 Presumably it was meant to hide the section below
<div class="experiment"
- jsselect="supportedExperiments"
+ jsselect="supportedFeatures"
jsvalues="id:internal_name">
<table width="100%" cellpadding="2" cellspacing="0">
<!-- TODO(mkwst): This doesn't work exactly as expected for multivalue
@@ -138,15 +132,9 @@
</div>
<div class="content">
- <div class="experiment-name no-experiments"
- jsdisplay="unsupportedExperiments.length == 0">
- <div i18n-content="flagsNoUnsupportedExperiments"
- >NO_UNSUPPORTED_EXPERIMENTS</div>
- </div>
-
- <div jsdisplay="unsupportedExperiments.length > 0">
+ <div jsdisplay="unsupportedFeatures.length > 0">
<div class="experiment"
- jsselect="unsupportedExperiments"
+ jsselect="unsupportedFeatures"
jsvalues="id:internal_name">
<table width="100%" cellpadding="2" cellspacing="0">
<tr class="experiment-unsupported">
« no previous file with comments | « components/flags_ui/resources/flags.css ('k') | components/flags_ui/resources/flags.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698