Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: components/flags_ui/resources/flags.html

Issue 1407753002: Clean up terminology used in about_flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comment on FeatureEntry. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/flags_ui/resources/flags.css ('k') | components/flags_ui/resources/flags.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!doctype html> 1 <!doctype html>
2 <html i18n-values="dir:textdirection;lang:language"> 2 <html i18n-values="dir:textdirection;lang:language">
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <meta charset="utf-8">
5 <if expr="is_android or is_ios"> 5 <if expr="is_android or is_ios">
6 <meta name="viewport" content="width=device-width, user-scalable=no"> 6 <meta name="viewport" content="width=device-width, user-scalable=no">
7 </if> 7 </if>
8 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> 8 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">
9 <link rel="stylesheet" href="flags.css"> 9 <link rel="stylesheet" href="flags.css">
10 10
(...skipping 21 matching lines...) Expand all
32 <span id="channel-promo-beta" i18n-content="channelPromoBeta" hidden></span> 32 <span id="channel-promo-beta" i18n-content="channelPromoBeta" hidden></span>
33 <span id="channel-promo-dev" i18n-content="channelPromoDev" hidden></span> 33 <span id="channel-promo-dev" i18n-content="channelPromoDev" hidden></span>
34 </div> 34 </div>
35 35
36 <if expr="chromeos"> 36 <if expr="chromeos">
37 <div class="blurb-container" id="owner-warning"> 37 <div class="blurb-container" id="owner-warning">
38 <span i18n-content="ownerWarning"></span> 38 <span i18n-content="ownerWarning"></span>
39 </div> 39 </div>
40 </if> 40 </if>
41 41
42 <div id="flagsExperimentTemplate"> 42 <div id="flagsTemplate">
43 <div id="container" class="vbox-container"> 43 <div id="container" class="vbox-container">
44 <div id="top" class="wbox"> 44 <div id="top" class="wbox">
45 <div class="section-header"> 45 <div class="section-header">
46 <table cellpadding="0" cellspacing="0"><tr valign="center"> 46 <table cellpadding="0" cellspacing="0"><tr valign="center">
47 <td> 47 <td>
48 <span class="section-header-title" i18n-content="flagsTableTitle" 48 <span class="section-header-title" i18n-content="flagsTableTitle"
49 >TITLE</span> 49 >TITLE</span>
50 <button id="experiment-reset-all" type="button" 50 <button id="experiment-reset-all" type="button"
51 i18n-content="resetAllButton"></button> 51 i18n-content="resetAllButton"></button>
52 </td> 52 </td>
53 </tr></table> 53 </tr></table>
54 </div> 54 </div>
55 </div> 55 </div>
56 </div> 56 </div>
57 57
58 <div class="content"> 58 <div class="content">
59 <div class="experiment-name no-experiments" 59 <div jsdisplay="supportedFeatures.length > 0">
James Hawkins 2015/10/14 20:34:40 What is the point of this div? It also appears to
Alexei Svitkine (slow) 2015/10/14 20:58:42 Presumably it was meant to hide the section below
60 jsdisplay="supportedExperiments.length == 0">
61 <div i18n-content="flagsNoExperimentsAvailable"
62 >NO_EXPERIMENTS_ARE_AVAILABLE</div>
63 </div>
64
65 <div jsdisplay="supportedExperiments.length > 0">
66 <div class="experiment" 60 <div class="experiment"
67 jsselect="supportedExperiments" 61 jsselect="supportedFeatures"
68 jsvalues="id:internal_name"> 62 jsvalues="id:internal_name">
69 <table width="100%" cellpadding="2" cellspacing="0"> 63 <table width="100%" cellpadding="2" cellspacing="0">
70 <!-- TODO(mkwst): This doesn't work exactly as expected for multivalue 64 <!-- TODO(mkwst): This doesn't work exactly as expected for multivalue
71 experiments. See http://crbug.com/73730 --> 65 experiments. See http://crbug.com/73730 -->
72 <tr jsvalues="class: is_default ? 'experiment-default' 66 <tr jsvalues="class: is_default ? 'experiment-default'
73 : 'experiment-switched'"> 67 : 'experiment-switched'">
74 <td valign="top"> 68 <td valign="top">
75 <div class="experiment-text"> 69 <div class="experiment-text">
76 <div> 70 <div>
77 <span class="experiment-name" 71 <span class="experiment-name"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 jsdisplay="!enabled" 104 jsdisplay="!enabled"
111 href="#" 105 href="#"
112 i18n-content="enable" 106 i18n-content="enable"
113 >ENABLE</a> 107 >ENABLE</a>
114 </span> 108 </span>
115 </div> 109 </div>
116 </td> 110 </td>
117 </tr> 111 </tr>
118 </table> 112 </table>
119 </div> 113 </div>
120 </div> 114 </div>
Nico 2015/10/14 20:40:26 closing tag is here
121 </div> 115 </div>
122 116
123 <!-- Unsupported experiments are not shown on iOS --> 117 <!-- Unsupported experiments are not shown on iOS -->
124 <if expr="not is_ios"> 118 <if expr="not is_ios">
125 <div id="container" class="vbox-container"> 119 <div id="container" class="vbox-container">
126 <div id="top" class="wbox"> 120 <div id="top" class="wbox">
127 <div class="section-header"> 121 <div class="section-header">
128 <table cellpadding="0" cellspacing="0"><tr valign="center"> 122 <table cellpadding="0" cellspacing="0"><tr valign="center">
129 <td> 123 <td>
130 <span class="section-header-title" 124 <span class="section-header-title"
131 i18n-content="flagsUnsupportedTableTitle" 125 i18n-content="flagsUnsupportedTableTitle"
132 >TITLE 126 >TITLE
133 </span> 127 </span>
134 </td> 128 </td>
135 </tr></table> 129 </tr></table>
136 </div> 130 </div>
137 </div> 131 </div>
138 </div> 132 </div>
139 133
140 <div class="content"> 134 <div class="content">
141 <div class="experiment-name no-experiments" 135 <div jsdisplay="unsupportedFeatures.length > 0">
142 jsdisplay="unsupportedExperiments.length == 0">
143 <div i18n-content="flagsNoUnsupportedExperiments"
144 >NO_UNSUPPORTED_EXPERIMENTS</div>
145 </div>
146
147 <div jsdisplay="unsupportedExperiments.length > 0">
148 <div class="experiment" 136 <div class="experiment"
149 jsselect="unsupportedExperiments" 137 jsselect="unsupportedFeatures"
150 jsvalues="id:internal_name"> 138 jsvalues="id:internal_name">
151 <table width="100%" cellpadding="2" cellspacing="0"> 139 <table width="100%" cellpadding="2" cellspacing="0">
152 <tr class="experiment-unsupported"> 140 <tr class="experiment-unsupported">
153 <td valign="top"> 141 <td valign="top">
154 <div class="experiment-text"> 142 <div class="experiment-text">
155 <div> 143 <div>
156 <span class="experiment-name" 144 <span class="experiment-name"
157 jscontent="name">NAME</span> 145 jscontent="name">NAME</span>
158 <span jscontent="supported_platforms.join(', ')"></span> 146 <span jscontent="supported_platforms.join(', ')"></span>
159 <div> 147 <div>
(...skipping 19 matching lines...) Expand all
179 <div i18n-content="flagsRestartNotice">NEEDS_RESTART</div> 167 <div i18n-content="flagsRestartNotice">NEEDS_RESTART</div>
180 <button class="experiment-restart-button" type="button" 168 <button class="experiment-restart-button" type="button"
181 i18n-content="flagsRestartButton">RESTART</button> 169 i18n-content="flagsRestartButton">RESTART</button>
182 </div> 170 </div>
183 </div> 171 </div>
184 </div> 172 </div>
185 <script src="chrome://resources/js/i18n_template.js"></script> 173 <script src="chrome://resources/js/i18n_template.js"></script>
186 <script src="chrome://resources/js/jstemplate_compiled.js"></script> 174 <script src="chrome://resources/js/jstemplate_compiled.js"></script>
187 </body> 175 </body>
188 </html> 176 </html>
OLDNEW
« no previous file with comments | « components/flags_ui/resources/flags.css ('k') | components/flags_ui/resources/flags.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698