Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 14077011: Views: Use the new button style instead of native-styled buttons. (Closed)

Created:
7 years, 8 months ago by msw
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina, sky
Visibility:
Public.

Description

Views: Use the new button style instead of native-styled buttons. Force STYLE_BUTTON instead of STYLE_NATIVE_TEXTBUTTON. ( easier to revert than replacing all uses, if necessary ) Make STYLE_BUTTON focusable like STYLE_NATIVE_TEXTBUTTON. Give default STYLE_BUTTON buttons bold text. Make STYLE_BUTTON buttons big enough for bolded text. ( so they'll fit bold text when made default without resizing ) See before/after pics at http://crbug.com/155363#c62 TODO(followup): Tweak individual buttons' layout as needed. TODO(followup): Officialy deprecate/remove STYLE_NATIVE_TEXTBUTTON. BUG=155363 TEST=The new button style appears everywhere as intended. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194673

Patch Set 1 #

Patch Set 2 : Remove the new dialog style dependency. #

Patch Set 3 : Make STYLE_BUTTON focusable like STYLE_NATIVE_TEXTBUTTON. #

Patch Set 4 : Give default STYLE_BUTTON buttons bold text. #

Patch Set 5 : Accomodate bold text for STYLE_BUTTON default buttons. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M ui/views/controls/button/label_button.cc View 1 2 3 4 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Scott, please take a look; thanks! This bold text accommodation here makes this CL ...
7 years, 8 months ago (2013-04-17 00:24:36 UTC) #1
msw
Added before/after pics at http://crbug.com/155363#c62
7 years, 8 months ago (2013-04-17 00:29:14 UTC) #2
msw
Hey Ben, please take a look; thanks!
7 years, 8 months ago (2013-04-17 08:14:38 UTC) #3
Ben Goodger (Google)
lgtm
7 years, 8 months ago (2013-04-17 20:05:24 UTC) #4
msw
7 years, 8 months ago (2013-04-17 21:09:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 manually as r194673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698