Views: Use the new button style instead of native-styled buttons.

ui/views/controls/button/label_button.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/label_button.h"
 
 #include "base/logging.h"
 #include "grit/ui_resources.h"
 #include "ui/base/animation/throb_animation.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 102 matching lines @@
   label_->SetHorizontalAlignment(alignment);
   InvalidateLayout();
 }
 
 void LabelButton::SetIsDefault(bool is_default) {
   if (is_default == is_default_)
     return;
   is_default_ = is_default;
   ui::Accelerator accel(ui::VKEY_RETURN, ui::EF_NONE);
   is_default_ ? AddAccelerator(accel) : RemoveAccelerator(accel);
+
+  // STYLE_BUTTON uses bold text to indicate default buttons.
+  if (style_ == STYLE_BUTTON) {
+    int style = label_->font().GetStyle();
+    style = is_default ? style | gfx::Font::BOLD : style & !gfx::Font::BOLD;
+    label_->SetFont(label_->font().DeriveFont(0, style));
+  }
 }
 
 void LabelButton::SetStyle(ButtonStyle style) {
+  // Use the new button style instead of the native button style.
+  // TODO(msw): Officialy deprecate and remove STYLE_NATIVE_TEXTBUTTON.
+  if (style == STYLE_NATIVE_TEXTBUTTON)
+    style = STYLE_BUTTON;
+
   style_ = style;
   set_border(new LabelButtonBorder(style));
   // Inset the button focus rect from the actual border; roughly match Windows.
   if (style == STYLE_TEXTBUTTON || style == STYLE_NATIVE_TEXTBUTTON)
     set_focus_border(FocusBorder::CreateDashedFocusBorder(3, 3, 3, 3));
-  if (style == STYLE_BUTTON || style == STYLE_NATIVE_TEXTBUTTON)
+  if (style == STYLE_BUTTON || style == STYLE_NATIVE_TEXTBUTTON) {
     label_->SetHorizontalAlignment(gfx::ALIGN_CENTER);
-  if (style == STYLE_NATIVE_TEXTBUTTON)
     set_focusable(true);
+  }
   if (style == STYLE_BUTTON) {
     set_min_size(gfx::Size(70, 31));
     const SkColor color = GetNativeTheme()->GetSystemColor(
       ui::NativeTheme::kColorId_WindowBackground);
     label_->SetShadowColors(color, color);
     label_->SetShadowOffset(0, 1);
   }
   // Invalidate the layout to pickup the new insets from the border.
   InvalidateLayout();
   ResetColorsFromNativeTheme();
 }
 
 gfx::Size LabelButton::GetPreferredSize() {
+  // Accomodate bold text in case this STYLE_BUTTON button is ever made default.
+  const gfx::Font font = label_->font();
+  if (style_ == STYLE_BUTTON)
+    label_->SetFont(font.DeriveFont(0, font.GetStyle() | gfx::Font::BOLD));
+
   // Resize multi-line labels paired with images to use their available width.
   const gfx::Size image_size(image_->GetPreferredSize());
   if (GetTextMultiLine() && !image_size.IsEmpty() && !GetText().empty() &&
       GetHorizontalAlignment() == gfx::ALIGN_CENTER) {
     label_->SizeToFit(GetLocalBounds().width() - image_size.width() - kSpacing);
   }
 
   // Calculate the required size.
   gfx::Size size(label_->GetPreferredSize());
   if (image_size.width() > 0 && size.width() > 0)
     size.Enlarge(kSpacing, 0);
   size.set_height(std::max(size.height(), image_size.height()));
   size.Enlarge(image_size.width() + GetInsets().width(), GetInsets().height());
 
+  // Restore the label's original font without the temporary bold style.
+  if (style_ == STYLE_BUTTON)
+    label_->SetFont(font);
+
   // Increase the minimum size monotonically with the preferred size.
   size.SetSize(std::max(min_size_.width(), size.width()),
                std::max(min_size_.height(), size.height()));
   min_size_ = size;
 
   // Return the largest known size clamped to the maximum size (if valid).
   if (max_size_.width() > 0)
     size.set_width(std::min(max_size_.width(), size.width()));
   if (max_size_.height() > 0)
     size.set_height(std::min(max_size_.height(), size.height()));
@@ skipping 140 matching lines @@
   params->button.indeterminate = false;
   params->button.is_default = is_default_;
   params->button.is_focused = HasFocus() && IsAccessibilityFocusable();
   params->button.has_border = style() == STYLE_NATIVE_TEXTBUTTON;
   params->button.classic_state = 0;
   params->button.background_color = GetNativeTheme()->GetSystemColor(
       ui::NativeTheme::kColorId_TextButtonBackgroundColor);
 }
 
 }  // namespace views