third_party/WebKit/Source/wtf/text/TextCodec.h - Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodec.h

Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Saving UTF16 with BOM. Leaving UTF32 in a broken state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebPageSerializerImpl.cpp ('K') | « third_party/WebKit/Source/web/WebPageSerializerImpl.cpp ('k') | third_party/WebKit/Source/wtf/text/TextCodec.cpp » ('j') | third_party/WebKit/Source/wtf/text/TextEncoding.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/TextCodec.h

diff --git a/third_party/WebKit/Source/wtf/text/TextCodec.h b/third_party/WebKit/Source/wtf/text/TextCodec.h

index 27e312858bd7bfe9743e3c32e96927c96b1946b3..f8a67ed60af2a85354ba062d2f9b7c0695ebcad9 100644

--- a/third_party/WebKit/Source/wtf/text/TextCodec.h

+++ b/third_party/WebKit/Source/wtf/text/TextCodec.h

@@ -86,6 +86,7 @@ public:

virtual String decode(const char*, size_t length, FlushBehavior, bool stopOnError, bool& sawError) = 0;

virtual CString encode(const UChar*, size_t length, UnencodableHandling) = 0;

virtual CString encode(const LChar*, size_t length, UnencodableHandling) = 0;

+ virtual bool shouldIncludeBOM();

// Fills a null-terminated string representation of the given

// unencodable character into the given replacement buffer.