third_party/WebKit/Source/wtf/text/TextCodec.cpp - Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodec.cpp

Issue 1407663004: Tweaking WebPageSerializerImpl to emit a BOM for UTF16/32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Saving UTF16 with BOM. Leaving UTF32 in a broken state. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebPageSerializerImpl.cpp ('K') | « third_party/WebKit/Source/wtf/text/TextCodec.h ('k') | third_party/WebKit/Source/wtf/text/TextCodecUTF16.h » ('j') | third_party/WebKit/Source/wtf/text/TextEncoding.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/TextCodec.cpp

diff --git a/third_party/WebKit/Source/wtf/text/TextCodec.cpp b/third_party/WebKit/Source/wtf/text/TextCodec.cpp

index 3cff46e96b9c7762e6ec3d610676de7e811828fc..7b6e724b284123bb733748b0d7d3770dda7ba9aa 100644

--- a/third_party/WebKit/Source/wtf/text/TextCodec.cpp

+++ b/third_party/WebKit/Source/wtf/text/TextCodec.cpp

@@ -54,4 +54,10 @@ int TextCodec::getUnencodableReplacement(unsigned codePoint, UnencodableHandling

return 0;

}

+bool TextCodec::shouldIncludeBOM()

+ // Do not include BOM by default.

+ return false;

} // namespace WTF