Add quotation marks around probability value in Alternative Services.

net/spdy/spdy_alt_svc_wire_format_test.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_alt_svc_wire_format.h"
 
 #include "base/logging.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/platform_test.h"
 
@@ skipping 70 matching lines @@
     header_field_value->append("mA=1111");
     if (i & 2 << 2) {
       header_field_value->append(" ");
     }
   }
   if (i & 1 << 4) {
     header_field_value->append("; J=s");
   }
   if (i & 1 << 5) {
     expected_altsvc->probability = 0.33;
-    header_field_value->append("; P=.33");
+    header_field_value->append("; P=\".33\"");
   }
   if (i & 1 << 6) {
     expected_altsvc->probability = 0.0;
     expected_altsvc->version = 24;
-    header_field_value->append("; p=0;v=24");
+    header_field_value->append("; p=\"0\";v=24");
   }
   if (i & 1 << 7) {
     expected_altsvc->max_age = 999999999;
     header_field_value->append("; Ma=999999999");
   }
   if (i & 1 << 8) {
     expected_altsvc->probability = 0.0;
-    header_field_value->append("; P=0.");
+    header_field_value->append("; P=\"0.\"");
   }
   if (i & 1 << 9) {
     header_field_value->append(";");
   }
   if (i & 1 << 10) {
     header_field_value->append(" ");
   }
   if (i & 1 << 11) {
     header_field_value->append(",");
   }
@@ skipping 19 matching lines @@
   if (i & 1 << 1) {
     altsvc->version = 24;
     expected_header_field_value->append("; v=24");
   }
   if (i & 1 << 2) {
     altsvc->max_age = 1111;
     expected_header_field_value->append("; ma=1111");
   }
   if (i & 1 << 3) {
     altsvc->probability = 0.33;
-    expected_header_field_value->append("; p=0.33");
+    expected_header_field_value->append("; p=\"0.33\"");
   }
 }
 
 class SpdyAltSvcWireFormatTest : public ::testing::Test {};
 
 // Tests of public API.
 
 TEST(SpdyAltSvcWireFormatTest, DefaultValues) {
   SpdyAltSvcWireFormat::AlternativeService altsvc;
   EXPECT_EQ("", altsvc.protocol_id);
@@ skipping 106 matching lines @@
 
 // ParseHeaderFieldValue() should return false on malformed field values:
 // invalid percent encoding, unmatched quotation mark, empty port, non-numeric
 // characters in numeric fields, negative or larger than 1.0 probability.
 TEST(SpdyAltSvcWireFormatTest, ParseHeaderFieldValueInvalid) {
   SpdyAltSvcWireFormat::AlternativeServiceVector altsvc_vector;
   const char* invalid_field_value_array[] = {"a%", "a%x", "a%b", "a%9z",
       "a=", "a=\"", "a=\"b\"", "a=\":\"", "a=\"c:\"", "a=\"c:foo\"",
       "a=\"c:42foo\"", "a=\"b:42\"bar", "a=\"b:42\" ; m",
       "a=\"b:42\" ; min-age", "a=\"b:42\" ; ma", "a=\"b:42\" ; ma=",
-      "a=\"b:42\" ; ma=ma", "a=\"b:42\" ; ma=123bar", "a=\"b:42\" ; p=-2",
-      "a=\"b:42\" ; p=..", "a=\"b:42\" ; p=1.05",
-      "a=\"b:42\" ; v=-3", "a=\"b:42\" ; v=1.2"};
+      "a=\"b:42\" ; ma=ma", "a=\"b:42\" ; ma=123bar", "a=\"b:42\" ; p=\"-2\"",
+      "a=\"b:42\" ; p=\"..\"", "a=\"b:42\" ; p=\"1.05\"", "a=\"b:42\" ; p=0.4",
+      "a=\"b:42\" ; p=\" 1.0\"", "a=\"b:42\" ; v=-3", "a=\"b:42\" ; v=1.2"};
   for (const char* invalid_field_value : invalid_field_value_array) {
     EXPECT_FALSE(SpdyAltSvcWireFormat::ParseHeaderFieldValue(
         invalid_field_value, &altsvc_vector))
         << invalid_field_value;
   }
 }
 
 // ParseHeaderFieldValue() should return false on a field values truncated
 // before closing quotation mark, without trying to access memory beyond the end
 // of the input.
@@ skipping 219 matching lines @@
     StringPiece input(invalid_input);
     double probability;
     EXPECT_FALSE(test::SpdyAltSvcWireFormatPeer::ParseProbability(
         input.begin(), input.end(), &probability));
   }
 }
 
 }  // namespace
 
 }  // namespace net