snapshot/win/process_snapshot_win.h - Issue 1407643004: Some plumbing for the beginning of getting handles into snapshot/minidump

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_snapshot_win.h

Issue 1407643004: Some plumbing for the beginning of getting handles into snapshot/minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@handles-redux

Patch Set: . Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/process_snapshot_win.h

diff --git a/snapshot/win/process_snapshot_win.h b/snapshot/win/process_snapshot_win.h

index a38ac5e9382b2cf16e9ba5295df2c2534d7f6e08..3bbe918c380c0c1c9bb813267f98c7514ef96955 100644

--- a/snapshot/win/process_snapshot_win.h

+++ b/snapshot/win/process_snapshot_win.h

@@ -129,6 +129,7 @@ class ProcessSnapshotWin final : public ProcessSnapshot {

std::vector<const ModuleSnapshot*> Modules() const override;

const ExceptionSnapshot* Exception() const override;

std::vector<const MemoryMapRegionSnapshot*> MemoryMap() const override;

+ std::vector<HandleSnapshot> Handles() const override;

std::vector<const MemorySnapshot*> ExtraMemory() const override;

private:

« no previous file with comments | « snapshot/test/test_process_snapshot.cc ('k') | snapshot/win/process_snapshot_win.cc » ('j') | util/win/process_info.h » ('J')