Some plumbing for the beginning of getting handles into snapshot/minidump

util/win/process_info.h

Index: util/win/process_info.h
diff --git a/util/win/process_info.h b/util/win/process_info.h
index 019e945c6e0ad3124688135dad0d091068589db4..104128998b5bf892823d69109aa2bbecb3e66cc6 100644
--- a/util/win/process_info.h
+++ b/util/win/process_info.h
@@ -140,7 +140,7 @@ class ProcessInfo {
       const CheckedRange<WinVMAddress, WinVMSize>& range) const;
 
   //! \brief Retrieves information about open handles in the target process.
-  const std::vector<Handle>& Handles();
+  const std::vector<Handle>& Handles() const;
 
  private:
   template <class Traits>
@@ -168,7 +168,10 @@ class ProcessInfo {
   WinVMSize peb_size_;
   std::vector<Module> modules_;
   std::vector<MEMORY_BASIC_INFORMATION64> memory_info_;
-  std::vector<Handle> handles_;
+
+  // Handles() is logically const, but updates this member on first retrieval.

[Mark Mentovai, 2015/10/16 22:39:24]

Reference https://code.google.com/p/crashpad/issues/detail?id=9. This const
problem is getting out of hand, we should fix it.

[scottmg, 2015/10/16 22:52:19]

Done.

It does seem sort of "right" for Snapshot to be all const, but in practice
laziness always seems to eventually make const interfaces troublesome.

+  mutable std::vector<Handle> handles_;
+
   bool is_64_bit_;
   bool is_wow64_;
   InitializationStateDcheck initialized_;