Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Unified Diff: snapshot/test/test_process_snapshot.cc

Issue 1407643004: Some plumbing for the beginning of getting handles into snapshot/minidump (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@handles-redux
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/test/test_process_snapshot.cc
diff --git a/snapshot/test/test_process_snapshot.cc b/snapshot/test/test_process_snapshot.cc
index d388c6016a100a80279cde820fb53621b7f49752..4d8726eb90b2e5dc42e6aaf0b6bbfd424ef43d8f 100644
--- a/snapshot/test/test_process_snapshot.cc
+++ b/snapshot/test/test_process_snapshot.cc
@@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
+#include "base/logging.h"
#include "snapshot/exception_snapshot.h"
#include "snapshot/system_snapshot.h"
#include "snapshot/test/test_process_snapshot.h"
@@ -107,6 +108,11 @@ std::vector<const MemoryMapRegionSnapshot*> TestProcessSnapshot::MemoryMap()
return memory_map;
}
+std::vector<HandleSnapshot> TestProcessSnapshot::Handles() const {
+ CHECK(false);
Mark Mentovai 2015/10/14 23:55:13 Would be easy to implement, but if there’s no use
scottmg 2015/10/16 20:51:02 Implemented, I was just planning to do it in a fol
+ return std::vector<HandleSnapshot>();
+}
+
std::vector<const MemorySnapshot*> TestProcessSnapshot::ExtraMemory() const {
std::vector<const MemorySnapshot*> extra_memory;
for (const auto& em : extra_memory_)

Powered by Google App Engine
This is Rietveld 408576698