Some plumbing for the beginning of getting handles into snapshot/minidump

snapshot/test/test_process_snapshot.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+#include "base/logging.h"
 #include "snapshot/exception_snapshot.h"
 #include "snapshot/system_snapshot.h"
 #include "snapshot/test/test_process_snapshot.h"
 
 namespace crashpad {
 namespace test {
 
 TestProcessSnapshot::TestProcessSnapshot()
     : process_id_(0),
       parent_process_id_(0),
@@ skipping 75 matching lines @@
 }
 
 std::vector<const MemoryMapRegionSnapshot*> TestProcessSnapshot::MemoryMap()
     const {
   std::vector<const MemoryMapRegionSnapshot*> memory_map;
   for (const auto& item : memory_map_)
     memory_map.push_back(item);
   return memory_map;
 }
 
+std::vector<HandleSnapshot> TestProcessSnapshot::Handles() const {
+  CHECK(false);

[Mark Mentovai, 2015/10/14 23:55:13]

Would be easy to implement, but if there’s no use for it and you’re not going
to, you should say so in a comment.

[scottmg, 2015/10/16 20:51:02]

Implemented, I was just planning to do it in a follow up once there's actually
test code calling it.

+  return std::vector<HandleSnapshot>();
+}
+
 std::vector<const MemorySnapshot*> TestProcessSnapshot::ExtraMemory() const {
   std::vector<const MemorySnapshot*> extra_memory;
   for (const auto& em : extra_memory_)
     extra_memory.push_back(em);
   return extra_memory;
 }
 
 }  // namespace test
 }  // namespace crashpad