third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html - Issue 1407633003: [css-grid] Implementation of Baseline Self-Alignment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html

Issue 1407633003: [css-grid] Implementation of Baseline Self-Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get advantage of recomputing the intrinsic size to solve the issues with orthogonal flows. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-baseline-vertical.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html » ('j') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html

diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html

index 2f47e4b6e50d5c360e2d6af4cd603672097912eb..451a1b386b4c27e88983a653cc6b95f9f80f6c45 100644

--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html

+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline.html

@@ -94,7 +94,7 @@ of the grey box

<div>

should align with the bottom

-<div class="empty inline-grid" style="width: 30px; height: 30px;">

+<div class="inline-grid" style="width: 30px; height: 30px">

</div>

of the grey box

</div>