Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 1407633003: [css-grid] Implementation of Baseline Self-Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch rebased and applied several refactoring and code clean up. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutGrid.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h
index d491a58eea490dda7508fbf8a25957f1c3546162..76e42f65e3743dd747a853082943b54790af5f11 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h
@@ -37,6 +37,7 @@ struct ContentAlignmentData;
struct GridArea;
struct GridSpan;
class GridTrack;
+class BaselineGroup;
enum TrackSizeComputationPhase {
ResolveIntrinsicMinimums,
@@ -47,6 +48,7 @@ enum TrackSizeComputationPhase {
MaximizeTracks,
};
enum GridAxisPosition { GridAxisStart, GridAxisEnd, GridAxisCenter };
+enum GridAxis { GridRowAxis, GridColumnAxis };
svillar 2017/01/19 09:41:25 We already have ForRows, ForColumns. Adding anothe
class LayoutGrid final : public LayoutBlock {
public:
@@ -318,7 +320,32 @@ class LayoutGrid final : public LayoutBlock {
LinePositionMode = PositionOnContainingLine) const override;
int firstLineBoxBaseline() const override;
int inlineBlockBaseline(LineDirectionMode) const override;
- bool isInlineBaselineAlignedChild(const LayoutBox* child) const;
+
+ bool isHorizontalGridAxis(GridAxis) const;
+ bool isParallelToBlockAxisForChild(const LayoutBox&, GridAxis) const;
+ bool isDescentBaselineForChild(const LayoutBox&, GridAxis) const;
+ bool isBaselineAlignmentForChild(const LayoutBox&,
+ GridAxis = GridColumnAxis) const;
+ const BaselineGroup& getBaselineGroupForChild(const LayoutBox&,
+ const GridSizingData&,
+ GridAxis) const;
+
+ LayoutUnit marginOverForChild(const LayoutBox&, GridAxis) const;
+ LayoutUnit logicalAscentForChild(const LayoutBox&, GridAxis) const;
+ LayoutUnit ascentForChild(const LayoutBox&, GridAxis) const;
+ LayoutUnit descentForChild(const LayoutBox&,
+ LayoutUnit ascent,
+ GridAxis) const;
+
+ void computeBaselineAlignmentContext(GridSizingData&) const;
+ void updateBaselineAlignmentContextIfNeeded(LayoutBox&,
+ GridSizingData&,
+ GridAxis) const;
+
+ LayoutUnit columnAxisBaselineOffsetForChild(const LayoutBox&,
+ const GridSizingData&) const;
+ LayoutUnit rowAxisBaselineOffsetForChild(const LayoutBox&,
+ const GridSizingData&) const;
#if ENABLE(ASSERT)
bool tracksAreWiderThanMinTrackBreadth(GridTrackSizingDirection,

Powered by Google App Engine
This is Rietveld 408576698