third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-07.html - Issue 1407633003: [css-grid] Implementation of Baseline Self-Alignment

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-07.html

Issue 1407633003: [css-grid] Implementation of Baseline Self-Alignment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Get advantage of recomputing the intrinsic size to solve the issues with orthogonal flows. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-06-expected.html ('k') | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-horiz-07-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link href="resources/grid.css" rel="stylesheet">

	3 <link href="resources/grid-alignment.css" rel="stylesheet">

	4 <style>

	5 body { margin: 0; }

	6 .block {

	7 background: grey;

	8 float: left;

	9 margin: 5px;

	10 text-orientation: sideways;

	11 width: 200px;

	12 height: 300px;

	13 }

	14 .block > :nth-child(1) { font-size:24px; }

	15 .block > :nth-child(2) { font-size:32px; }

	16 .block > :nth-child(3) { font-size:48px; }

	17 .block > :nth-child(4) { font-size:64px; }

	18 .item {

	19 border-width: 2px 5px 3px 4px;

	20 border-style: solid;

	21 padding: 6px 3px 7px 8px;

	22 margin: 10px 6px 4px 12px;

	23 }

	24 .extraLeftPadding { padding-left: 30px; }

	25 .extraRightPadding { padding-right: 30px; }

	26 .column { grid-auto-flow: row }

	27 </style>

	28

	29 <p>4x1 with orthogonal items, but opposite block-flow direction.<br>No item shar es any row-like Baseline Context. All items share 'first-column' Baseline Contex t.<br>We have 2 baseline-sharing groups.<br>Items participate in both, column an d row baseline, but since they only share a column-like Baseline Context only 'j ustify-self' (row baseline-axis) should apply.<br>The Baseline Alignment may inc rease size contribution of some items.</p>

	30 <div class="block grid column contentStart itemsBaseline">

	31 <div class="item verticalLR">A</div>

	32 <div class="item verticalLR">A</div>

	33 <div class="item verticalRL">A</div>

	34 <div class="item verticalRL">A</div>

	35 </div>

	36 <div class="block grid column contentStart itemsBaseline">

	37 <div class="item verticalLR extraRightPadding">A</div>

	38 <div class="item verticalLR extraLeftPadding">A</div>

	39 <div class="item verticalRL">A</div>

	40 <div class="item verticalRL">A</div>

	41 </div>

OLD	NEW