Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: minor bug fix (perspective does not clear paint offset). switch test to unit test style. add a few … Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
index 702089fc1520b4ab9e945607d00d7264a577ee71..84e47e59c616b2419562f462d01499aba4c7de7c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
@@ -43,5 +43,9 @@ void RenderingTest::SetUp()
document().view()->updateAllLifecyclePhases();
}
+void RenderingTest::TearDown()
pdr. 2015/10/20 22:02:30 Is this necessary? It should happen automatically
jbroman 2015/10/20 23:50:13 trchen answered this question when I asked it earl
trchen 2015/10/21 06:16:19 Still needed otherwise either an assertion goes of
+{
+ m_pageHolder = nullptr;
+}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698