Preliminary paint property walk implementation for SPv2

third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/layout/LayoutTestHelper.h"
 
 #include "core/loader/EmptyClients.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/graphics/GraphicsLayerFactory.h"
@@ skipping 25 matching lines @@
     fillWithEmptyClients(pageClients);
     DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<FakeChromeClient>, chromeClient, (FakeChromeClient::create()));
     pageClients.chromeClient = chromeClient.get();
     m_pageHolder = DummyPageHolder::create(IntSize(800, 600), &pageClients, nullptr, settingOverrider());
 
     // This ensures that the minimal DOM tree gets attached
     // correctly for tests that don't call setBodyInnerHTML.
     document().view()->updateAllLifecyclePhases();
 }
 
+void RenderingTest::TearDown()

[pdr., 2015/10/20 22:02:30]

Is this necessary? It should happen automatically as part of the regular test
runner lifecycle (either in SetUp or in the dtor).

[jbroman, 2015/10/20 23:50:13]

trchen answered this question when I asked it earlier, but if that ordering
issue still exists, it merits a comment here, please, if only so we stop asking.
:)

[trchen, 2015/10/21 06:16:19]

Still needed otherwise either an assertion goes off or we left dangling mapping.
Both sound terrible so let me add a comment. :)

+{
+    m_pageHolder = nullptr;
+}
 
 } // namespace blink