third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp - Issue 1407543003: Preliminary paint property walk implementation for SPv2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

Issue 1407543003: Preliminary paint property walk implementation for SPv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address the feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.cpp ('K') | « third_party/WebKit/Source/core/layout/LayoutTestHelper.h ('k') | third_party/WebKit/Source/core/paint/ObjectPaintProperties.h » ('j') | third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

index 702089fc1520b4ab9e945607d00d7264a577ee71..83641fe3f6170d113c8197c705d7891e981e5459 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp

@@ -43,5 +43,12 @@ void RenderingTest::SetUp()

document().view()->updateAllLifecyclePhases();

}

+void RenderingTest::TearDown()

+ // We need to destroy most of the Blink structure here because derived tests may restore

+ // RuntimeEnabledFeatures setting during teardown, which happens before our destructor

+ // getting invoked, breaking the assumption that REF can't change during Blink lifetime.

+ m_pageHolder = nullptr;

} // namespace blink