Start EmbeddedWorker during registration - take 2

content/browser/service_worker/embedded_worker_instance.cc

Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index 7cfd5cbbac994c693026549af6e21e7730739e33..b7d52961e405cc0247009424b966776b13767838 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -18,9 +18,12 @@ EmbeddedWorkerInstance::~EmbeddedWorkerInstance() {
 bool EmbeddedWorkerInstance::Start(
     int64 service_worker_version_id,
     const GURL& script_url) {
+  LOG(ERROR) << "Starting EmbeddedWorkerInstance";

[kinuko, 2014/01/29 09:56:20]

You could add these logs with DVLOG(1) so that we can keep useful logging in the
debug build

[alecflett, 2014/01/30 01:51:13]

I don't think these are super useful, all of the LOG(ERROR)'s will be going
away... they're mostly for when I was debugging test failures.

   DCHECK(status_ == STOPPED);
-  if (!ChooseProcess())
+  if (!ChooseProcess()) {
+    LOG(ERROR) << "Couldnl't find process to run worker..";

[kinuko, 2014/01/29 09:56:20]

I'm changing StartWorker() to return PROCESS_NOT_FOUND error code so that you
could use it...

[alecflett, 2014/01/30 01:51:13]

Yep, will do!

     return false;
+  }
   status_ = STARTING;
   bool success = registry_->StartWorker(
       process_id_,
@@ -74,6 +77,7 @@ EmbeddedWorkerInstance::EmbeddedWorkerInstance(
       status_(STOPPED),
       process_id_(-1),
       thread_id_(-1) {
+  LOG(ERROR) << "Creating EmbeddedWorkerInstance";
 }
 
 void EmbeddedWorkerInstance::OnStarted(int thread_id) {