Start EmbeddedWorker during registration - take 2

content/browser/service_worker/embedded_worker_instance.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/embedded_worker_instance.h"
 
 #include "content/browser/service_worker/embedded_worker_registry.h"
 #include "content/common/service_worker/embedded_worker_messages.h"
 #include "ipc/ipc_message.h"
 #include "url/gurl.h"
 
 namespace content {
 
 EmbeddedWorkerInstance::~EmbeddedWorkerInstance() {
   registry_->RemoveWorker(process_id_, embedded_worker_id_);
 }
 
 bool EmbeddedWorkerInstance::Start(
     int64 service_worker_version_id,
     const GURL& script_url) {
+  LOG(ERROR) << "Starting EmbeddedWorkerInstance";

[kinuko, 2014/01/29 09:56:20]

You could add these logs with DVLOG(1) so that we can keep useful logging in the
debug build

[alecflett, 2014/01/30 01:51:13]

I don't think these are super useful, all of the LOG(ERROR)'s will be going
away... they're mostly for when I was debugging test failures.

   DCHECK(status_ == STOPPED);
-  if (!ChooseProcess())
+  if (!ChooseProcess()) {
+    LOG(ERROR) << "Couldnl't find process to run worker..";

[kinuko, 2014/01/29 09:56:20]

I'm changing StartWorker() to return PROCESS_NOT_FOUND error code so that you
could use it...

[alecflett, 2014/01/30 01:51:13]

Yep, will do!

     return false;
+  }
   status_ = STARTING;
   bool success = registry_->StartWorker(
       process_id_,
       embedded_worker_id_,
       service_worker_version_id,
       script_url);
   if (!success) {
     status_ = STOPPED;
     process_id_ = -1;
   }
@@ skipping 33 matching lines @@
 }
 
 EmbeddedWorkerInstance::EmbeddedWorkerInstance(
     EmbeddedWorkerRegistry* registry,
     int embedded_worker_id)
     : registry_(registry),
       embedded_worker_id_(embedded_worker_id),
       status_(STOPPED),
       process_id_(-1),
       thread_id_(-1) {
+  LOG(ERROR) << "Creating EmbeddedWorkerInstance";
 }
 
 void EmbeddedWorkerInstance::OnStarted(int thread_id) {
   // Stop is requested before OnStarted is sent back from the worker.
   if (status_ == STOPPING)
     return;
   DCHECK(status_ == STARTING);
   status_ = RUNNING;
   thread_id_ = thread_id;
   FOR_EACH_OBSERVER(Observer, observer_list_, OnStarted());
@@ skipping 29 matching lines @@
         max_ref_iter->second < iter->second)
       max_ref_iter = iter;
   }
   if (max_ref_iter == process_refs_.end())
     return false;
   process_id_ = max_ref_iter->first;
   return true;
 }
 
 }  // namespace content