Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: content/browser/accessibility/site_per_process_accessibility_browsertest.cc

Issue 1407413002: Move some AX attrs from AXNodeData to AXTreeData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/site_per_process_accessibility_browsertest.cc
diff --git a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
index 192b11c9efaaf304354e075de0e921448d87100f..647985ccf7127a41175ff01571dcc52efcc5e219 100644
--- a/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
+++ b/content/browser/accessibility/site_per_process_accessibility_browsertest.cc
@@ -41,7 +41,7 @@ class SitePerProcessAccessibilityBrowserTest
bool AccessibilityTreeContainsDocTitle(
BrowserAccessibility* node,
const std::string& title) {
- if (node->GetStringAttribute(ui::AX_ATTR_DOC_TITLE) == title)
+ if (node->GetStringAttribute(ui::AX_ATTR_NAME) == title)
return true;
for (unsigned i = 0; i < node->PlatformChildCount(); i++) {
if (AccessibilityTreeContainsDocTitle(node->PlatformGetChild(i), title))
@@ -53,9 +53,8 @@ bool AccessibilityTreeContainsDocTitle(
// Utility function to determine if an accessibility tree has finished loading
// or if the tree represents a page that hasn't finished loading yet.
bool AccessibilityTreeIsLoaded(BrowserAccessibilityManager* manager) {
- BrowserAccessibility* root = manager->GetRoot();
- return (root->GetFloatAttribute(ui::AX_ATTR_DOC_LOADING_PROGRESS) == 1.0 &&
- root->GetStringAttribute(ui::AX_ATTR_DOC_URL) != url::kAboutBlankURL);
+ return (manager->GetTreeData().loading_progress == 1.0 &&
+ manager->GetTreeData().url != url::kAboutBlankURL);
}
// Times out on Android, not clear if it's an actual bug or just slow.

Powered by Google App Engine
This is Rietveld 408576698