chrome/common/extensions/chrome_extension_messages.h - Issue 1407413002: Move some AX attrs from AXNodeData to AXTreeData.

Unified Diff: chrome/common/extensions/chrome_extension_messages.h

Issue 1407413002: Move some AX attrs from AXNodeData to AXTreeData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/aura/accessibility/ax_tree_source_aura.cc ('k') | chrome/renderer/extensions/automation_internal_custom_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/chrome_extension_messages.h

diff --git a/chrome/common/extensions/chrome_extension_messages.h b/chrome/common/extensions/chrome_extension_messages.h

index 23d494c0bae6de05a03a8f3eadb278f71dc8684f..637016c04c6b6f8fe886c6187b7f905a863270cb 100644

--- a/chrome/common/extensions/chrome_extension_messages.h

+++ b/chrome/common/extensions/chrome_extension_messages.h

@@ -19,6 +19,7 @@

#include "ipc/ipc_message_macros.h"

#include "ui/accessibility/ax_enums.h"

#include "ui/accessibility/ax_node_data.h"

+#include "ui/accessibility/ax_tree_data.h"

#include "ui/accessibility/ax_tree_update.h"

#include "url/gurl.h"

@@ -68,7 +69,24 @@ IPC_STRUCT_TRAITS_BEGIN(ui::AXNodeData)

IPC_STRUCT_TRAITS_MEMBER(child_ids)

IPC_STRUCT_TRAITS_END()

-IPC_STRUCT_TRAITS_BEGIN(ui::AXTreeUpdate<ui::AXNodeData>)

+IPC_STRUCT_TRAITS_BEGIN(ui::AXTreeData)

+ IPC_STRUCT_TRAITS_MEMBER(tree_id)

dmazzoni 2015/10/22 18:30:17 Note to reviewers: all of these fields were previo

Tom Sepez 2015/10/22 18:54:04 Acknowledged.

+ IPC_STRUCT_TRAITS_MEMBER(parent_tree_id)

+ IPC_STRUCT_TRAITS_MEMBER(url)

+ IPC_STRUCT_TRAITS_MEMBER(title)

+ IPC_STRUCT_TRAITS_MEMBER(mimetype)

+ IPC_STRUCT_TRAITS_MEMBER(doctype)

+ IPC_STRUCT_TRAITS_MEMBER(loaded)

+ IPC_STRUCT_TRAITS_MEMBER(loading_progress)

+ IPC_STRUCT_TRAITS_MEMBER(sel_anchor_object_id)

+ IPC_STRUCT_TRAITS_MEMBER(sel_anchor_offset)

+ IPC_STRUCT_TRAITS_MEMBER(sel_focus_object_id)

+ IPC_STRUCT_TRAITS_MEMBER(sel_focus_offset)

+IPC_STRUCT_TRAITS_END()

+IPC_STRUCT_TRAITS_BEGIN(ui::AXTreeUpdate)

+ IPC_STRUCT_TRAITS_MEMBER(has_tree_data)

+ IPC_STRUCT_TRAITS_MEMBER(tree_data)

IPC_STRUCT_TRAITS_MEMBER(node_id_to_clear)

IPC_STRUCT_TRAITS_MEMBER(nodes)

IPC_STRUCT_TRAITS_END()

@@ -81,7 +99,7 @@ IPC_STRUCT_BEGIN(ExtensionMsg_AccessibilityEventParams)

IPC_STRUCT_MEMBER(gfx::Vector2d, location_offset)

// The tree update.

- IPC_STRUCT_MEMBER(ui::AXTreeUpdate<ui::AXNodeData>, update)

+ IPC_STRUCT_MEMBER(ui::AXTreeUpdate, update)

// Type of event.

IPC_STRUCT_MEMBER(ui::AXEvent, event_type)