Move some AX attrs from AXNodeData to AXTreeData.

Move some AX attrs from AXNodeData to AXTreeData.

Previously all accessibility attributes had to be stored
in AXNodeData. The root of a tree had a lot of extra
attributes that only applied to that node. This introduces
AXTreeData, a simple serializable struct with the data
that applies to the whole tree, including the title, url,
loading progress, and selection information. Later it will
include focus information too.

Note: this CL doesn't change any functionality or
send any new data via an IPC, it just refactors
things.

BUG=none

Committed: https://crrev.com/329fd011fab6f531f5131256f6b6d3920041e3c1
Cr-Commit-Position: refs/heads/master@{#355626}

[dmazzoni, 2015-10-16 22:41:01]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[dmazzoni, 2015-10-16 22:42:25]

This is a big refactoring. I still need to finish fixing automation/chromevox
and make sure it compiles on all
platforms, but please take a quick look sooner if possible
so I don't waste as much time if you have general feedback.
Thanks.

[David Tseng, 2015-10-19 18:21:38]

https://codereview.chromium.org/1407413002/diff/60001/chrome/renderer/extensi...
File chrome/renderer/extensions/automation_internal_custom_bindings.cc (right):

https://codereview.chromium.org/1407413002/diff/60001/chrome/renderer/extensi...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:119:
ROUTE_FUNCTION(GetDocURL);
I would like to see us to re-use get*Attribute here. Maybe just add a
getRoot*Attribute binding (e.g. getRootStringAttribute) or
getTreeStringAttribute.

[dmazzoni, 2015-10-19 22:37:38]

Updated to remove a lot of boilerplate in automation_internal_custom_bindings.
Please take a look!

[David Tseng, 2015-10-20 23:26:17]

lgtm



[dmazzoni, 2015-10-20 23:50:33]

dmazzoni@chromium.org changed reviewers:
+ dcheng@chromium.org, jam@chromium.org

[dmazzoni, 2015-10-20 23:50:33]

+dcheng for *messages*
+jam for other content/ approvals

[jam, 2015-10-21 15:35:38]

lgtm

[dmazzoni, 2015-10-22 18:29:32]

Description was changed from

==========
Move some AX attrs from AXNodeData to AXTreeData.

Previously all accessibility attributes had to be stored
in AXNodeData. The root of a tree had a lot of extra
attributes that only applied to that node. This introduces
AXTreeData, a simple serializable struct with the data
that applies to the whole tree, including the title, url,
loading progress, and selection information. Later it will
include focus information too.

BUG=none
==========

to

==========
Move some AX attrs from AXNodeData to AXTreeData.

Previously all accessibility attributes had to be stored
in AXNodeData. The root of a tree had a lot of extra
attributes that only applied to that node. This introduces
AXTreeData, a simple serializable struct with the data
that applies to the whole tree, including the title, url,
loading progress, and selection information. Later it will
include focus information too.

Note: this CL doesn't change any functionality or
send any new data via an IPC, it just refactors
things.

BUG=none
==========

[dmazzoni, 2015-10-22 18:30:17]

https://codereview.chromium.org/1407413002/diff/280001/chrome/common/extensio...
File chrome/common/extensions/chrome_extension_messages.h (right):

https://codereview.chromium.org/1407413002/diff/280001/chrome/common/extensio...
chrome/common/extensions/chrome_extension_messages.h:73:
IPC_STRUCT_TRAITS_MEMBER(tree_id)
Note to reviewers: all of these fields were previously in AXTreeUpdate below, as
members of the root AXNodeData in the "nodes" member. So this is just
refactoring, it's not actually sending any new data over IPC.

[dmazzoni, 2015-10-22 18:31:03]

dmazzoni@chromium.org changed reviewers:
+ tsepez@chromium.org

[dmazzoni, 2015-10-22 18:31:04]

+tsepez to review just the *message* IPC files

[Tom Sepez, 2015-10-22 18:54:04]

Messages LGTM

https://codereview.chromium.org/1407413002/diff/280001/chrome/common/extensio...
File chrome/common/extensions/chrome_extension_messages.h (right):

https://codereview.chromium.org/1407413002/diff/280001/chrome/common/extensio...
chrome/common/extensions/chrome_extension_messages.h:73:
IPC_STRUCT_TRAITS_MEMBER(tree_id)
On 2015/10/22 18:30:17, dmazzoni wrote:
> Note to reviewers: all of these fields were previously in AXTreeUpdate below,
as
> members of the root AXNodeData in the "nodes" member. So this is just
> refactoring, it's not actually sending any new data over IPC.

Acknowledged.

[dmazzoni, 2015-10-22 18:57:38]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-10-22 18:57:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1407413002/#ps280001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-22 18:58:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407413002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407413002/280001

[commit-bot: I haz the power, 2015-10-22 19:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 19:08:58]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2015-10-22 19:18:48]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-10-22 19:19:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1407413002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1407413002/280001

[commit-bot: I haz the power, 2015-10-22 20:06:15]

Committed patchset #15 (id:280001)

[commit-bot: I haz the power, 2015-10-22 20:07:10]

Patchset 15 (id:??) landed as
https://crrev.com/329fd011fab6f531f5131256f6b6d3920041e3c1
Cr-Commit-Position: refs/heads/master@{#355626}