Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407393005: Get tools/test.py --noopt green. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Get tools/test.py --noopt green. More specifically ./tools/test.py --noopt -mall -ax64,simarm,simarm64,simmips --exclude-suite=pkg - Add missing dart:io entry point. - Add checks that Dart_FinalizeLoading, Dart_Precompile, Dart_CreatePrecompiledSnapshot are called in order. - Add checks for --precompilation flag. - Add checks for dropped class in Dart_New/Allocate/AllocateWithNativeFields. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/371a5dc93236359acb97e8bcf406c532538d5878

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 9

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -1 line) Patch
M runtime/bin/main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/secure_socket.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 7 chunks +26 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +22 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
5 years, 2 months ago (2015-10-21 16:44:05 UTC) #2
rmacnak
5 years, 2 months ago (2015-10-21 16:44:41 UTC) #4
Florian Schneider
Lgtm. Thanks! https://codereview.chromium.org/1407393005/diff/40001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/1407393005/diff/40001/tests/co19/co19-runtime.status#newcode92 tests/co19/co19-runtime.status:92: LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout Would 'Pass, Slow' to ...
5 years, 2 months ago (2015-10-21 17:01:45 UTC) #5
rmacnak
https://codereview.chromium.org/1407393005/diff/40001/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/1407393005/diff/40001/tests/co19/co19-runtime.status#newcode92 tests/co19/co19-runtime.status:92: LibTest/collection/ListBase/ListBase_class_A01_t02: Pass, Timeout On 2015/10/21 17:01:45, Florian Schneider wrote: ...
5 years, 2 months ago (2015-10-21 17:32:22 UTC) #6
rmacnak
5 years, 2 months ago (2015-10-21 17:35:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
371a5dc93236359acb97e8bcf406c532538d5878 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698