Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: runtime/vm/precompiler.cc

Issue 1407393005: Get tools/test.py --noopt green. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/precompiler.cc
diff --git a/runtime/vm/precompiler.cc b/runtime/vm/precompiler.cc
index 70f1c85816b54612185bf530467158996311c12e..7182f80921fed13df4ecbb7bb2e026786c46460c 100644
--- a/runtime/vm/precompiler.cc
+++ b/runtime/vm/precompiler.cc
@@ -880,6 +880,14 @@ void Precompiler::FinalizeAllClasses() {
for (intptr_t i = 0; i < libraries_.Length(); i++) {
lib ^= libraries_.At(i);
+ if (!lib.Loaded()) {
+ String& uri = String::Handle(Z, lib.url());
+ String& msg = String::Handle(Z, String::NewFormatted(
+ "Library '%s' is not loaded. "
+ "Did you forget to call Dart_FinalizeLoading?", uri.ToCString()));
+ Jump(Error::Handle(Z, ApiError::New(msg)));
+ }
+
ClassDictionaryIterator it(lib, ClassDictionaryIterator::kIteratePrivate);
while (it.HasNext()) {
cls = it.GetNextClass();
« no previous file with comments | « runtime/vm/object_test.cc ('k') | tests/co19/co19-runtime.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698