Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1407373007: Remove CallFunctionStub, always call through the Call builtin (also from CallIC) (Closed)

Created:
5 years, 1 month ago by Toon Verwaest
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, v8-mips-ports, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove CallFunctionStub, always call through the Call builtin (also from CallIC). This fixes receiver conversion since the Call builtin does it correctly. BUG=v8:4526 LOG=n Committed: https://crrev.com/44c44521ae11859478b42004f57ea93df52526ee Cr-Commit-Position: refs/heads/master@{#31823}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -1247 lines) Patch
M src/arm/code-stubs-arm.cc View 5 chunks +8 lines, -159 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 5 chunks +8 lines, -174 lines 0 comments Download
M src/code-factory.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/code-factory.cc View 2 chunks +5 lines, -16 lines 0 comments Download
M src/code-stubs.h View 3 chunks +0 lines, -37 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 5 chunks +7 lines, -14 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 9 chunks +13 lines, -16 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 9 chunks +13 lines, -16 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 9 chunks +13 lines, -15 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 9 chunks +13 lines, -16 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 9 chunks +13 lines, -16 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 9 chunks +13 lines, -15 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +8 lines, -159 lines 0 comments Download
M src/ic/ic.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/ic/ic-state.h View 2 chunks +1 line, -11 lines 0 comments Download
M src/ic/ic-state.cc View 1 chunk +1 line, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 5 chunks +8 lines, -159 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 5 chunks +8 lines, -161 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +8 lines, -166 lines 0 comments Download
A test/mjsunit/call-cross-realm.js View 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-4525.js View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Toon Verwaest
ptal
5 years, 1 month ago (2015-11-05 09:25:46 UTC) #12
Benedikt Meurer
LGTM, Nice!
5 years, 1 month ago (2015-11-05 09:34:44 UTC) #13
Toon Verwaest
@v8-mips-ports: Could you please port this CL to mips/mips64?
5 years, 1 month ago (2015-11-05 09:39:49 UTC) #15
Toon Verwaest
Added mips ports myself.
5 years, 1 month ago (2015-11-05 12:21:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407373007/210001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407373007/210001
5 years, 1 month ago (2015-11-05 12:21:57 UTC) #19
akos.palfi.imgtec
I also uploaded the ports in https://codereview.chromium.org/1415573013 . They are the same as yours and ...
5 years, 1 month ago (2015-11-05 12:38:47 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:210001)
5 years, 1 month ago (2015-11-05 12:45:48 UTC) #22
commit-bot: I haz the power
5 years, 1 month ago (2015-11-05 12:46:14 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44c44521ae11859478b42004f57ea93df52526ee
Cr-Commit-Position: refs/heads/master@{#31823}

Powered by Google App Engine
This is Rietveld 408576698