Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: src/crankshaft/hydrogen.cc

Issue 1407373007: Remove CallFunctionStub, always call through the Call builtin (also from CallIC) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/crankshaft/hydrogen.cc
diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc
index e0dd98984a63d99c18e1e5947998d95654131007..bf0572a41fbe6724593711193d44dff7e32d27bf 100644
--- a/src/crankshaft/hydrogen.cc
+++ b/src/crankshaft/hydrogen.cc
@@ -6589,7 +6589,7 @@ HValue* HOptimizedGraphBuilder::BuildMonomorphicAccess(
if (info->NeedsWrappingFor(info->accessor())) {
HValue* function = Add<HConstant>(info->accessor());
PushArgumentsFromEnvironment(argument_count);
- return New<HCallFunction>(function, argument_count, WRAP_AND_CALL);
+ return New<HCallFunction>(function, argument_count);
} else if (FLAG_inline_accessors && can_inline_accessor) {
bool success = info->IsLoad()
? TryInlineGetter(info->accessor(), info->map(), ast_id, return_id)
@@ -8169,10 +8169,9 @@ void HOptimizedGraphBuilder::HandlePolymorphicCallNamed(Call* expr,
// use the regular CallFunctionStub for method calls to wrap the receiver.
// TODO(verwaest): Support creation of value wrappers directly in
// HWrapReceiver.
- HInstruction* call = needs_wrapping
- ? NewUncasted<HCallFunction>(
- function, argument_count, WRAP_AND_CALL)
- : BuildCallConstantFunction(target, argument_count);
+ HInstruction* call =
+ needs_wrapping ? NewUncasted<HCallFunction>(function, argument_count)
+ : BuildCallConstantFunction(target, argument_count);
PushArgumentsFromEnvironment(argument_count);
AddInstruction(call);
Drop(1); // Drop the function.
@@ -8201,10 +8200,7 @@ void HOptimizedGraphBuilder::HandlePolymorphicCallNamed(Call* expr,
environment()->SetExpressionStackAt(0, receiver);
CHECK_ALIVE(VisitExpressions(expr->arguments()));
- CallFunctionFlags flags = receiver->type().IsJSObject()
- ? NO_CALL_FUNCTION_FLAGS : CALL_AS_METHOD;
- HInstruction* call = New<HCallFunction>(
- function, argument_count, flags);
+ HInstruction* call = New<HCallFunction>(function, argument_count);
PushArgumentsFromEnvironment(argument_count);
@@ -9707,8 +9703,7 @@ void HOptimizedGraphBuilder::VisitCall(Call* expr) {
// the receiver.
// TODO(verwaest): Support creation of value wrappers directly in
// HWrapReceiver.
- call = New<HCallFunction>(
- function, argument_count, WRAP_AND_CALL);
+ call = New<HCallFunction>(function, argument_count);
} else if (TryInlineCall(expr)) {
return;
} else {
@@ -9731,9 +9726,7 @@ void HOptimizedGraphBuilder::VisitCall(Call* expr) {
Push(receiver);
CHECK_ALIVE(VisitExpressions(expr->arguments(), arguments_flag));
- CallFunctionFlags flags = receiver->type().IsJSObject()
- ? NO_CALL_FUNCTION_FLAGS : CALL_AS_METHOD;
- call = New<HCallFunction>(function, argument_count, flags);
+ call = New<HCallFunction>(function, argument_count);
}
PushArgumentsFromEnvironment(argument_count);
« no previous file with comments | « src/crankshaft/arm64/lithium-codegen-arm64.cc ('k') | src/crankshaft/hydrogen-instructions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698