Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: components/favicon/core/favicon_driver.cc

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_driver.cc
diff --git a/components/favicon/core/favicon_driver.cc b/components/favicon/core/favicon_driver.cc
index 00632292c6a889942a4a546c958d870bc6353b7e..e94034e3e78de657713851b770c654fc021e0529 100644
--- a/components/favicon/core/favicon_driver.cc
+++ b/components/favicon/core/favicon_driver.cc
@@ -4,8 +4,6 @@
#include "components/favicon/core/favicon_driver.h"
-#include "components/favicon/core/favicon_driver_observer.h"
-
namespace favicon {
void FaviconDriver::AddObserver(FaviconDriverObserver* observer) {
@@ -22,14 +20,14 @@ FaviconDriver::FaviconDriver() {
FaviconDriver::~FaviconDriver() {
}
-void FaviconDriver::NotifyFaviconAvailable(const gfx::Image& image) {
- FOR_EACH_OBSERVER(FaviconDriverObserver, observer_list_,
- OnFaviconAvailable(image));
-}
-
-void FaviconDriver::NotifyFaviconUpdated(bool icon_url_changed) {
+void FaviconDriver::NotifyFaviconUpdatedObservers(
+ FaviconDriverObserver::NotificationIconType notification_icon_type,
+ const GURL& icon_url,
+ bool icon_url_changed,
+ const gfx::Image& image) {
FOR_EACH_OBSERVER(FaviconDriverObserver, observer_list_,
- OnFaviconUpdated(this, icon_url_changed));
+ OnFaviconUpdated(this, notification_icon_type, icon_url,
+ icon_url_changed, image));
}
} // namespace favicon

Powered by Google App Engine
This is Rietveld 408576698