Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/favicon/core/favicon_driver.h ('K') | « components/favicon/core/favicon_driver.cc ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | components/favicon/core/favicon_driver_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon/core/favicon_driver_impl.h
diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h
index f1ef6a1d5a65c6328fa24d9f6d28a4d184c4f76a..54e8d3aeec780c7fcf8157cfba46d59ec29e11e4 100644
--- a/components/favicon/core/favicon_driver_impl.h
+++ b/components/favicon/core/favicon_driver_impl.h
@@ -53,10 +53,6 @@ class FaviconDriverImpl : public FaviconDriver {
// FaviconDriver implementation.
void FetchFavicon(const GURL& url) override;
bool IsBookmarked(const GURL& url) override;
- void OnFaviconAvailable(const GURL& page_url,
- const GURL& icon_url,
- const gfx::Image& image,
- bool is_active_favicon) override;
bool HasPendingTasksForTest() override;
protected:
« components/favicon/core/favicon_driver.h ('K') | « components/favicon/core/favicon_driver.cc ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | components/favicon/core/favicon_driver_observer.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698