chrome/browser/favicon/content_favicon_driver_browsertest.cc - Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/content_favicon_driver_browsertest.cc

Issue 1407353012: Refactor FaviconDriver::OnFaviconAvailable() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@initial_simplify

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_event_router.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | components/favicon/content/content_favicon_driver.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/favicon/content_favicon_driver_browsertest.cc

diff --git a/chrome/browser/favicon/content_favicon_driver_browsertest.cc b/chrome/browser/favicon/content_favicon_driver_browsertest.cc

index 4ba0645e7e02d8c6603598d3d5a665c17dea4735..aec2d292b3aa4c0adad7a6e27a4ddae1761e35c7 100644

--- a/chrome/browser/favicon/content_favicon_driver_browsertest.cc

+++ b/chrome/browser/favicon/content_favicon_driver_browsertest.cc

@@ -142,9 +142,11 @@ class PendingTaskWaiter : public content::NotificationObserver,

}

// favicon::Favicon

- void OnFaviconAvailable(const gfx::Image& image) override {}

void OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,

- bool icon_url_changed) override {

+ NotificationIconType notification_icon_type,

+ const GURL& icon_url,

+ bool icon_url_changed,

+ const gfx::Image& image) override {

OnNotification();

}